Re: RFR 8042900: Allow com.sun.security.jgss to be in different module than org.ietf.jgss

2014-09-05 Thread Alan Bateman
On 28/08/2014 10:36, Wang Weijun wrote: Hi Alan Thanks for the review. All suggestions accepted. Change for S4U2selfGSS is not related and can be reverted. I've looked through webrev.01 and you've addressed all my comments. A small item but the new JgssExtender.java needs a copyright header b

Re: Review request for CR 8049039 Need new tests for sun.securiy.x509 classes

2014-09-05 Thread Jason Uh
Hi Raghu, Formatting looks good, but one last thing about the copyright headers. I noticed that in lines 7-9, you have the lines * ... Oracle designates this * particular file as subject to the "Classpath" exception as provided * by Oracle in the LICENSE file that accompanied this code.

Re: Review request for CR 8049039 Need new tests for sun.securiy.x509 classes

2014-09-05 Thread raghu k.nair
Hi Jason, Yes you are right. I will remove those lines from the code. Vincent, Could you please give an official node to commit these changes ? Thanks, Raghu On 9/6/2014 1:58 AM, Jason Uh wrote: Hi Raghu, Formatting looks good, but one last thing about the copyright headers. I noticed that