Re: JEP Review: JVM Hardware Crypto Acceleration

2014-09-30 Thread Florian Weimer
On 09/29/2014 10:33 PM, Anthony Scarpino wrote: Please review the below JEP for JVM Hardware Crypto Acceleration. The focus is to use ISA crypto instructions available in x86 and sparc platforms and to help access to use them. https://bugs.openjdk.java.net/browse/JDK-8046943 Can you show what

[9] RFR 8059462: Typo in keytool resource file

2014-09-30 Thread Vincent Ryan
Please review this correction to a key used by the keytool utility to access its L10N strings: Webrev: http://cr.openjdk.java.net/~vinnie/8059462/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8059462 Thanks.

Re: [9] RFR 8059462: Typo in keytool resource file

2014-09-30 Thread Wang Weijun
Change looks good. I think it can labelled noreg-trivial. Thanks Max On Sep 30, 2014, at 18:46, Vincent Ryan wrote: > Please review this correction to a key used by the keytool utility to access > its L10N strings: > > Webrev: http://cr.openjdk.java.net/~vinnie/8059462/webrev.00/ > Bug: https

Re: [9] RFR 8059462: Typo in keytool resource file

2014-09-30 Thread Vincent Ryan
Thanks for the quick review. On 30 Sep 2014, at 13:21, Wang Weijun wrote: > Change looks good. I think it can labelled noreg-trivial. > > Thanks > Max > > On Sep 30, 2014, at 18:46, Vincent Ryan wrote: > >> Please review this correction to a key used by the keytool utility to access >> its

Re: Fwd: Issue JDK-8048194 backport in jdk9 ?

2014-09-30 Thread Seán Coffey
Iris is correct. This fix is in JDK 9 only. I'm not sure why you think it's fixed in jdk8u. Max - are you willing to pull this fix into the JDK 8u code line or shall I ? regards, Sean. On 30/09/2014 07:56, Koen Serry wrote: Hi, could anyone merge the code of jdk9 into jdk8 as supposedly d

Re: JEP Review: JVM Hardware Crypto Acceleration

2014-09-30 Thread Anthony Scarpino
On 09/30/2014 02:51 AM, Florian Weimer wrote: On 09/29/2014 10:33 PM, Anthony Scarpino wrote: Please review the below JEP for JVM Hardware Crypto Acceleration. The focus is to use ISA crypto instructions available in x86 and sparc platforms and to help access to use them. https://bugs.openjdk.

Re: Issue JDK-8048194 backport in jdk9 ?

2014-09-30 Thread Wang Weijun
On Oct 1, 2014, at 0:05, Seán Coffey wrote: > Iris is correct. This fix is in JDK 9 only. I'm not sure why you think it's > fixed in jdk8u. > > Max - are you willing to pull this fix into the JDK 8u code line or shall I ? Public holiday here. Can you do it? Hopefully the patch is identical.