Re: com.sun.crypto.provider.GHASH performance fix

2015-01-20 Thread Florian Weimer
On 01/15/2015 05:24 PM, Anthony Scarpino wrote: >> Anthony, could you file a bug so that I can include its number? Thanks. >> > > Here it is: https://bugs.openjdk.java.net/browse/JDK-8069072 Thanks. Updated webrev: -- Florian Weimer

Re: com.sun.crypto.provider.GHASH performance fix

2015-01-20 Thread Florian Weimer
On 01/16/2015 09:18 AM, Anthony Scarpino wrote: >> On Jan 15, 2015, at 12:26 PM, Florian Weimer wrote: >> >> Yes, they are going to help quite a bit as well. The other thing we need to >> fix for TLS is that AES-GCM is a garbage collector stress test. Last time I >> looked, for each transferre

Re: [JDK-9] RFR: 8041787: Need new regressions tests for buffer handling for PBE algorithms

2015-01-20 Thread Vincent Ryan
The new tests look fine. Thanks. On 28 Jul 2014, at 08:15, Rajan Halade wrote: > May I request you to review these 4 new tests to be added for PBE keys. New > tests are added to address following: > > - same buffer can be used for encrypt and decrypt with PBE > - Mac update works correctly wi

[9] request for review: 8049171: Additional tests for jarsigner's warnings

2015-01-20 Thread Artem Smotrakov
Hello, Please review a couple of new tests for jarsigner's warnings. Basically tests run jarsigner and check warning/error messages and exit codes according to [1]. https://bugs.openjdk.java.net/browse/JDK-8049171 http://cr.openjdk.java.net/~asmotrak/8049171/webrev.00 [1] http://docs.oracle