Re: [9] request for review: 8049171: Additional tests for jarsigner's warnings

2015-01-26 Thread Wang Weijun
JarUtils: You can break after line 83. Otherwise very good. Thanks Max > On Jan 26, 2015, at 15:55, Artem Smotrakov wrote: > > Hi Max, > > Here is an updated webrev, please take a look. > > http://cr.openjdk.java.net/~asmotrak/8049171/webrev.02/ > > Artem > > On 01/26/2015 05:03 AM, Weiju

Re: [9] request for review: 8049171: Additional tests for jarsigner's warnings

2015-01-26 Thread Artem Smotrakov
On 01/26/2015 11:11 AM, Wang Weijun wrote: JarUtils: You can break after line 83. Sure, I have updated the webrev http://cr.openjdk.java.net/~asmotrak/8049171/webrev.03/ Otherwise very good. Thanks for reviewing this. Thanks Max On Jan 26, 2015, at 15:55, Artem Smotrakov wrote: Hi Max

RFR: 8061798: Add support for TLS_FALLBACK_SCSV

2015-01-26 Thread Florian Weimer
I have rebased the TLS_FALLBACK_SCSV implementation I submitted in October 2014 to the current jdk9-dev tree: The test uses an expired X.509 certificate (which was already part of the test suite), but this is harmless. TLS_FALLBACK_SCSV

RFR 8071562: TimestampCheck.java change removes a whitespace between command and args

2015-01-26 Thread Weijun Wang
Ah yes, a whitespace was mistakenly removed. Please review my fix at http://cr.openjdk.java.net/~weijun/8071562/webrev.00/ It's simply cmd = System.getProperty("java.home") + "/bin/jarsigner"; } - cmd += System.getProperty("test.tool.vm.opts") + cmd += " " + System.get

Re: RFR 8071562: TimestampCheck.java change removes a whitespace between command and args

2015-01-26 Thread Alan Bateman
On 26/01/2015 13:45, Weijun Wang wrote: Ah yes, a whitespace was mistakenly removed. Please review my fix at http://cr.openjdk.java.net/~weijun/8071562/webrev.00/ It's simply cmd = System.getProperty("java.home") + "/bin/jarsigner"; } - cmd += System.getProperty("test.too

Re: RFR 8022582: Relax response flags checking in sun.security.krb5.KrbKdcRep.check.

2015-01-26 Thread Sean Mullan
Typo on line 941 of KDC.java: s/senstives/sensitives Also the OS component of the bug is set to "solaris_10", which doesn't seem right. Looks ok otherwise. --Sean On 01/14/2015 11:10 PM, Wang Weijun wrote: Hi All Please review the code changes at http://cr.openjdk.java.net/~weijun/8022

Re: IndexOf with Char instead of String

2015-01-26 Thread Otávio Gonçalves de Santana
The same code, but using the new standard: http://cr.openjdk.java.net/~chegar/docs/portingScript.html How is the new standard I thought that I should create new thread. Sorry. On Sun, Jan 25, 2015 at 10:30 PM, Claes Redestad wrote: > Wait a minute. Is this the latest? Why start a new thread? >

Re: [9] RFR: 8042967: Add variant of DSA Signature algorithms that do not ASN.1 encode the signature bytes

2015-01-26 Thread Sean Mullan
On 01/25/2015 11:15 PM, Michael StJohns wrote: Sorry - I missed this the first time around I think this may not be the right approach... I'm concerned with trying to overload ECDSA and DSA which have always had relationships with very specific specifications and trying to make them also cov