Re: [9] RFR: 8054037: Improve tracing for java.security.debug=certpath (8055207)

Jason, I think you're missing the HandshakeMessage.java changes that Vinnie proposed. Everything else looks good to me. I'd suggest that you push your changeset with both the 8054037 and 8055207 bug IDs then. regards, Sean. On 02/03/2015 23:07, Jason Uh wrote: Thanks for the comments, Sean;

RFR(8u): 8072932: Test fails with java.security.AccessControlException: access denied ("java.security.SecurityPermission" "getDomainCombiner")

Hi, This is a review request for an 8u backport of the bug: https://bugs.openjdk.java.net/browse/JDK-8072932 It's a one-line change that backports cleanly: this is the 8u diff, shown after applying the change for 8064331 in 8u: (not hg imported, different paths) jdk8u-dev/jdk$ hg diff src/

Re: RFR(8u): 8072932: Test fails with java.security.AccessControlException: access denied ("java.security.SecurityPermission" "getDomainCombiner")

Hi Kevin, On 3.3.2015 14:29, Kevin Walls wrote: Hi, This is a review request for an 8u backport of the bug: https://bugs.openjdk.java.net/browse/JDK-8072932 It's a one-line change that backports cleanly: this is the 8u diff, shown after applying the change for 8064331 in 8u: (not hg imported,

Re: Please review CR8048360 Test signed jar files

Hi Max, Thanks for reviewing this changeset, could you please sponsor this? Regards, Amanda On 2/25/15 4:24 PM, Weijun Wang wrote: Looks fine. Thanks Max On 2/26/2015 4:41, Amanda Jiang wrote: Hi All, Could you please review following changeset for 1 new test, which check various combinati

Re: [9] RFR: 8054037: Improve tracing for java.security.debug=certpath (8055207)

Thanks for catching that. Here it is with the HandshakeMessage.java changes. I'll push with both bug IDs. On 03/03/2015 01:25 AM, Seán Coffey wrote: Jason, I think you're missing the HandshakeMessage.java changes that Vinnie proposed. Everything else looks good to me. I'd suggest that you push

Re: [9] RFR: 8054037: Improve tracing for java.security.debug=certpath (8055207)

http://cr.openjdk.java.net/~juh/8054037/02/ Looks good. regards, Sean. On 03/03/2015 18:25, Jason Uh wrote: Thanks for catching that. Here it is with the HandshakeMessage.java changes. I'll push with both bug IDs. On 03/03/2015 01:25 AM, Seán Coffey wrote: Jason, I think you're missing th

Re: RFR: 8074064 : OCSPResponse.SingleResponse objects do not parse singleExtensions

Hello all, I've come across a couple edge cases that this fix doesn't cover properly. I'll put out another webrev in a bit that should tighten up the singleResponse parsing, particularly with the optional fields. It will also include a couple other negative test input samples. Thanks, --Jami

RFR: [Updated] 8074064 : OCSPResponse.SingleResponse objects do not parse singleExtensions

Okay, I've got an updated webrev for this issue: http://cr.openjdk.java.net/~jnimeh/reviews/8074064/webrev.02/index.html Thanks, --Jamil On 03/03/2015 02:18 PM, Jamil Nimeh wrote: Hello all, I've come across a couple edge cases that this fix doesn't cover properly. I'll put out another webrev

Re: Please review CR8048360 Test signed jar files

Sure. Are you an OpenJDK author? If yes, the changset will have Author: amanda Otherwise, it will be Author: weijun Contributed-by: [email protected] --Max > On Mar 4, 2015, at 01:27, Amanda Jiang wrote: > > Hi Max, > > Thanks for reviewing this changeset, could you please spo

Re: Please review CR8048360 Test signed jar files

Hi Max, I don't have an author ID yet. Thanks, Amanda On 3/3/15 5:09 PM, Wang Weijun wrote: Sure. Are you an OpenJDK author? If yes, the changset will have Author: amanda Otherwise, it will be Author: weijun Contributed-by: [email protected] --Max On Mar 4, 2015, at 01:2

Re: Please review CR8048360 Test signed jar files

Done at http://hg.openjdk.java.net/jdk9/dev/jdk/rev/4503bd758762.

Re: [JDK-9] RFR: 8050371: MessageDigest tests

Looks fine to me. Thanks, Xuelei On 2/10/2015 3:46 PM, zaiyao liu wrote: > Hi all, > > Please help to review those 2 new tests to be added for MessageDigest, > New tests are added to address following: > > - Fixed length hash value is returned with different data inputs > - Same hash value is r

Re: [JDK-9] RFR: 8050371: MessageDigest tests

Hi Xuelei, Thanks for review, Can you help to push it? Full comments: 8050371: MessageDigest tests Reviewed-by: xuelei Contributed-by: Zaiyao Liu Thanks again. Kevin 在 2015/3/4 13:34, Xuelei Fan 写道: Looks fine to me. Thanks, Xuelei On 2/10/2015 3:46 PM, zaiyao liu wrote: Hi all, Please he

Re: [JDK-9] RFR: 8048610 Implement regression tests for bug fixes in JCE

Empty: - 29: I am not a fan of import static using like this, but you are free to do anyway - 34: "with expected message". You didn't check if the message is expected, you only check if it's empty - 39, 41, 43, 51: left brace should go back to previous lines - line 48 and 49 can be fit in one

skip-tls

Hello, I just run across this work from a team of researchers on TLS protocol fuzzing. One part of this article describes what CVE-2014-6593 is all about. https://www.smacktls.com/#skip I must say, I had a brief look into this while checking the fixes in the January CPU, but due to the rather lo

Re: [JDK-9] RFR: 8048610 Implement regression tests for bug fixes in JCE

Thanks Max, please review the update: http://cr.openjdk.java.net/~zailiu/8048610/webrev.01/webrev/ Kevin 在 2015/3/4 13:52, Weijun Wang 写道: Empty: - 29: I am not a fan of import static using like this, but you are free to do anyway - 34: "with expected message". You didn't check if the messa