Hi Jamil,
Just a few comments, mostly minor.
* OCSPResponse
768: there is an extra space in the indentation
811: use Collections.emptyMap instead of new HashMap<>() as that does
not allocate a new Map object.
813-15,861-63: Use Map.values instead of Map.keySet, ex:
for (Extension ext :
On 03/11/2015 07:38 AM, Sean Mullan wrote:
Hi Jamil,
Just a few comments, mostly minor.
* OCSPResponse
768: there is an extra space in the indentation
811: use Collections.emptyMap instead of new HashMap<>() as that does
not allocate a new Map object.
813-15,861-63: Use Map.values instead
Okay, an updated webrev has been posted that addresses Sean's comments
(thanks, BTW).
http://cr.openjdk.java.net/~jnimeh/reviews/8074064/webrev.04/
--Jamil
On 03/11/2015 07:38 AM, Sean Mullan wrote:
Hi Jamil,
Just a few comments, mostly minor.
* OCSPResponse
768: there is an extra space in
Hello all,
This bug moves the internal MacAlg concrete class to an enum, and alters
the CipherSuite constructor to no longer use String parsing on the
cipher suite name to determine the MacAlg. Instead, the constructor now
requires the caller to pass in a MacAlg, similar to how it already tak
Hello,
Please review the patch below to correct JDK-8075034: Bad javadoc tags
in javax.xml.crypto.dsig.
In several cases, the javadoc uses unescaped "<" and ">" characters
which is flagged as a problem by doclint. In addition, the javadoc as it
currently stands renders improperly and omits t
