Re: RFR 8047789: auth.login.LoginContext needs to be updated to work with modules

On 20/03/2015 14:39, Wang Weijun wrote: Please review the code changes at http://cr.openjdk.java.net/~weijun/8047789/webrev.03/ : Compatibility issue: Before this code change, any class that includes the necessary methods (initialize, login, logout, abort, commit) can be configured as a

Re: [JDK-9] RFR: 8048618 Tests for PKCS12 write operations

Looks fine. One small issue: LEAD_CERT does not have a "\n" before the "-END" line. Although X509Factory accepts it this is not correct. --Max > On Mar 19, 2015, at 14:04, zaiyao liu wrote: > > Hi Max, > > Thanks for review, > please check the update: > http://cr.openjdk.java.net/~zaili

Re: Code review of JDK-8072385, Only the first DNSName entry is checked for endpoint identification

Looks fine to me too. The isEquivalent() method name is not very precise IMHO, maybe hasSame()? Of course, if has same is what isEquivalent means then it's OK. :-) Thanks Max > On Mar 21, 2015, at 06:00, Jamil Nimeh wrote: > > Hi Xuelei, this looks good to me. > > --Jamil > > On 3/9/2015 10