Re: RFR 8056174: New APIs for jar signing

2015-03-26 Thread Mandy Chung
On 3/24/2015 2:47 AM, Wang Weijun wrote: Hi All Please review the code change at http://cr.openjdk.java.net/~weijun/8056174/webrev.00/ It provides a new jdk.Exported API JarSigner to perform jar signing. The class contains popular functions of the jarsigner tool. The jarsigner tool is un

Code Review Request: 8064546 CipherInputStream throws BadPaddingException if stream is not fully read

2015-03-26 Thread Anthony Scarpino
Hi, I'd like a review of the below webrev: http://cr.openjdk.java.net/~ascarpino/8064546/webrev/ The code change is very simple, where close() should not throw exceptions. Most of the code change is comments that are just informational The attached test goes through all the scenarios making

Re: DH Key sizes (again)

2015-03-26 Thread Sean Mullan
Hi Bernd, On 03/24/2015 07:28 AM, Bernd wrote: Hello, it is good to see Java 8 support EDH with 1024 and 2048 bit keys. However it is still a problem that there is no negotiation in the TLS handshake and so a flexible client should be able to accept different key siztes. Apache since 2.4.7 send

Re: RFR 8056174: New APIs for jar signing

2015-03-26 Thread Sean Mullan
On 03/24/2015 05:47 AM, Wang Weijun wrote: Hi All Please review the code change at http://cr.openjdk.java.net/~weijun/8056174/webrev.00/ It provides a new jdk.Exported API JarSigner to perform jar signing. The class contains popular functions of the jarsigner tool. The jarsigner tool is

Re: [9] RFR: 7145757: CertificateExtensions uses non-consistent key names

2015-03-26 Thread Jason Uh
Please review this revision: http://cr.openjdk.java.net/~juh/7145757/01/ * all get()/set() calls to CertificateExtensions and CRLExtensions is by OID * get()/set() from X509CertImpl/Info continue to work by name. ex: X509CertImpl.get("x509.info.extensions.") * a global nameCache is maintained

Re: RFR 8056174: New APIs for jar signing

2015-03-26 Thread Wang Weijun
> On Mar 27, 2015, at 04:41, Sean Mullan wrote: > > On 03/24/2015 05:47 AM, Wang Weijun wrote: >> Hi All >> >> Please review the code change at >> >>http://cr.openjdk.java.net/~weijun/8056174/webrev.00/ >> >> It provides a new jdk.Exported API JarSigner to perform jar signing. The >> cla