Re: RFR 7191662: JCE providers should be located via ServiceLoader

2015-06-05 Thread Erik Joelsson
Hello Valerie, The merging seems ok, but I thought there was non determinism in the image builder regarding which provider would get picked up. Is that resolved or do you really need to override all of those providers with your generated file in gensrc? I can assist in writing that makefile l

Re: TLS ALPN Proposal v2

2015-06-05 Thread Simone Bordet
Hi, On Fri, Jun 5, 2015 at 6:11 AM, Xuelei Fan wrote: > I think it should be true that if a server can negotiate h2, the server > MUST support H2 and the enabled cipher suites MUST contains at least one > H2 required cipher suite. Otherwise, it's bug in server side. > > It's instinctive that if

Re: TLS ALPN Proposal v2

2015-06-05 Thread Michael McMahon
I've just noticed the SSLParameters.setUseCipherSuitesOrder() method. I guess this can be used to enforce a higher priority for the h2 compatible ciphers on the server side. On the new API, I'm not sure about the SSLBase, SSLFunction construct either. I don't think it is very clear, and if its

RFR : 8080102: Java 8 cannot load its cacerts in FIPS. no such provider: SunEC

2015-06-05 Thread Seán Coffey
Looking to resolve a recently reported issue where the P11ECKeyFactory class has too much dependence on the SunEC provider. With some reshuffling and creation of a new P11ECUtil class, I was able to remove the call for lookup of SunEC Provider. The test picks up the regression when running with

Re: TLS ALPN Proposal v2

2015-06-05 Thread Xuelei Fan
See more inlines, please. Please help on one question I'm not sure of. Per HTTP/2 specification, Does H2 server allow fallback to HTTP/1.1 if client requests a HTTP/2 connection? I did not find the answer from RFC 7540. In TLS, if client requests to negotiate TLS v1.2, and server supports TLS 1

RFR [9] 8081517: minor cleanup for docs

2015-06-05 Thread alexander stepanov
Hello, Could you please review the fix http://cr.openjdk.java.net/~avstepan/8081517/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8081517 Just some cleanup for docs. Thanks, Alexander

Re: RFR [9] 8081517: minor cleanup for docs

2015-06-05 Thread Lance Andersen
Hi Alxander Overall. looks OK. A couple of things I thought could be changed; In FTPURLConnection, I probably would surround the code in an {@code} tag In VmIdentifier, I do not see think we still need in the tags Best Lance On Jun 5, 2015, at 8:51 AM, alexander stepanov wrote: > Hello,

Re: TLS ALPN Proposal v2

2015-06-05 Thread Simone Bordet
Hi, On Fri, Jun 5, 2015 at 2:36 PM, Xuelei Fan wrote: > See more inlines, please. > > Please help on one question I'm not sure of. Per HTTP/2 specification, > Does H2 server allow fallback to HTTP/1.1 if client requests a HTTP/2 > connection? I did not find the answer from RFC 7540. Yes. The i

Re: TLS ALPN Proposal v2

2015-06-05 Thread Xuelei Fan
On 6/5/2015 10:11 PM, Simone Bordet wrote: > On Fri, Jun 5, 2015 at 2:36 PM, Xuelei Fan wrote: >> > See more inlines, please. >> > >> > Please help on one question I'm not sure of. Per HTTP/2 specification, >> > Does H2 server allow fallback to HTTP/1.1 if client requests a HTTP/2 >> > connection

Re: TLS ALPN Proposal v2

2015-06-05 Thread Simone Bordet
Hi, On Fri, Jun 5, 2015 at 4:46 PM, Xuelei Fan wrote: > If H2 is not supported, SPDY/3.1 would be attempted, of SPDY/3.1 is not > supported HTTP/1.1 would be attempted. Correct. > If H2 is supported in both side, > but H2 does not work, it is a H2 problem that need to be addressed in H2 > layer

Re: TLS ALPN Proposal v2

2015-06-05 Thread Xuelei Fan
On 6/5/2015 11:16 PM, Simone Bordet wrote: > Hi, > > On Fri, Jun 5, 2015 at 4:46 PM, Xuelei Fan wrote: >> If H2 is not supported, SPDY/3.1 would be attempted, of SPDY/3.1 is not >> supported HTTP/1.1 would be attempted. > > Correct. > >> If H2 is supported in both side, >> but H2 does not work,

Re: JEP 232 RFR: JDK-8065942 and JDK-8056179

2015-06-05 Thread Weijun Wang
Hi Sean Everything is fine, some comments: FilePermission (also in SocketPermission, PropertyPermission, ServicePermission): int oldMask = ((FilePermission)existingVal).getMask(); int newMask = ((FilePermission)newVal).getMask(); if (oldMask != newMask) { int effective = o

RFR: 8077418: StackOverflowError during PolicyFile lookup

2015-06-05 Thread Seán Coffey
A regression has been discovered after JDK-8058547 was fixed in 8u60. For now, I'm proposing we back the fix out from the jdk8u-dev forest and plan a new fix. This is a straight-forward anti delta of 8058547 JDK 9 is not impacted since JDK-8055753 already removed this code. bug : https://bug

Re: JEP 232 RFR: JDK-8065942 and JDK-8056179

2015-06-05 Thread Sean Mullan
Thanks for the comments, Max. Replies below ... On 06/05/2015 11:44 AM, Weijun Wang wrote: Hi Sean Everything is fine, some comments: FilePermission (also in SocketPermission, PropertyPermission, ServicePermission): int oldMask = ((FilePermission)existingVal).getMask(); int newMask

Re: RFR : 8080102: Java 8 cannot load its cacerts in FIPS. no such provider: SunEC

2015-06-05 Thread Valerie Peng
This looks pretty good. However, I suspect this will stop working once the Jake changes are integrated as module boundaries are enforced? Valerie On 6/5/2015 3:21 AM, Seán Coffey wrote: Looking to resolve a recently reported issue where the P11ECKeyFactory class has too much dependence on th

Re: RFR: 8077418: StackOverflowError during PolicyFile lookup

2015-06-05 Thread Sean Mullan
Looks good. Please add noreg-other label to bug. --Sean On 06/05/2015 01:37 PM, Seán Coffey wrote: A regression has been discovered after JDK-8058547 was fixed in 8u60. For now, I'm proposing we back the fix out from the jdk8u-dev forest and plan a new fix. This is a straight-forward anti delt

Re: RFR 7191662: JCE providers should be located via ServiceLoader

2015-06-05 Thread Valerie Peng
I don't know image builder well enough to answer your question. Based on my own experiment, it seems to pick up the one from java.naming when duplication occurs, so that's why I saved the merged result to there and named the Gensrc makefile with java.naming. The result build work fine. Does

Re: JEP 232 RFR: JDK-8065942 and JDK-8056179

2015-06-05 Thread Weijun Wang
ServicePermission: We can also add a ServicePermission(String,int) like FilePermission has. --Max http://cr.openjdk.java.net/~mullan/webrevs/8065942-8056179/webrev.00/

Re: RFR 7191662: JCE providers should be located via ServiceLoader

2015-06-05 Thread Mandy Chung
> On Jun 5, 2015, at 4:32 PM, Valerie Peng wrote: > > > I don't know image builder well enough to answer your question. The current implementation of the image builder sorts the modules by their name that are mapped to the same class loader. That explains why java.naming is the first one co