Re: sun.security.x509.DNSName leading dot in name constraints

2015-06-09 Thread Sean Mullan
-Bcc jdk9-dev This question is more appropriate for security-dev, so I am copying that list for further discussion. --Sean On 06/09/2015 02:21 AM, Vyronas Tsingaras wrote: Hi all, I work for the Hellenic Academic and Research Institutions Certification Authority (https://www.harica.gr), a

Re: sun.security.x509.DNSName leading dot in name constraints

2015-06-09 Thread Sean Mullan
On 06/09/2015 07:21 AM, Sean Mullan wrote: -Bcc jdk9-dev This question is more appropriate for security-dev, so I am copying that list for further discussion. --Sean On 06/09/2015 02:21 AM, Vyronas Tsingaras wrote: Hi all, I work for the Hellenic Academic and Research Institutions Certificat

Re: [9] Review request for 8085979: Make some DTLS feature functional tests work also for TLS protocol

2015-06-09 Thread Xuelei Fan
Looks fine to me. Nice port to TLS protocols. A very minior comment about the class name. TLSUnSupportedCiphersTest.java: replease "UnSupported" with "Unsupported". Thanks, Xuelei On 6/8/2015 11:04 PM, Konstantin Shefov wrote: > Hello, > > Please review distribution of some DTLS feature tests

Re: [9] Review request for 8085979: Make some DTLS feature functional tests work also for TLS protocol

2015-06-09 Thread Xuelei Fan
On 6/9/2015 10:57 PM, Xuelei Fan wrote: > Looks fine to me. Nice port to TLS protocols. > > A very minior comment about the class name. > TLSUnSupportedCiphersTest.java: > replease "UnSupported" with "Unsupported". > typo: replace "UnSupported" with "Unsupported". > Thanks, > Xuelei > > On 6/8

Re: [9] Review request for 8085979: Make some DTLS feature functional tests work also for TLS protocol

2015-06-09 Thread Konstantin Shefov
Xuelei, thanks for reviewing typo is corrected: http://cr.openjdk.java.net/~kshefov/8085979/webrev.01/ -Konstantin On 06/09/2015 06:07 PM, Xuelei Fan wrote: On 6/9/2015 10:57 PM, Xuelei Fan wrote: Looks fine to me. Nice port to TLS protocols. A very minior comment about the class name. TLSU

Re: [9] Review request for 8085979: Make some DTLS feature functional tests work also for TLS protocol

2015-06-09 Thread Xuelei Fan
On 6/9/2015 11:31 PM, Konstantin Shefov wrote: > Xuelei, thanks for reviewing > > typo is corrected: > http://cr.openjdk.java.net/~kshefov/8085979/webrev.01/ > Why there are old "UnSupportedCiphersTest.java" files? If you have not committed the changeset, you can "hg forget" to undo a previous "

Re: [9] Review request for 8085979: Make some DTLS feature functional tests work also for TLS protocol

2015-06-09 Thread Xuelei Fan
On 6/9/2015 11:47 PM, Xuelei Fan wrote: > On 6/9/2015 11:31 PM, Konstantin Shefov wrote: >> Xuelei, thanks for reviewing >> >> typo is corrected: >> http://cr.openjdk.java.net/~kshefov/8085979/webrev.01/ >> > Why there are old "UnSupportedCiphersTest.java" files? If you have not > committed the ch