The logic in RefreshKrb5Config.java is very good. Why not also try
NotRefreshable again after writing the correct krb5.conf in BogusKDC.java?
Thanks
Max
On 07/16/2015 01:38 PM, Artem Smotrakov wrote:
Hello,
Please review a couple of new tests that check that:
- Kerberos client tries slave KDC
Hi All
Please take a look at
http://cr.openjdk.java.net/~weijun/8131350/webrev.00/
Policytool contains a lot of hard coded strings for permission class
names, which can be changed to actual Class types. That allows checking
at compile-time rather than failing at run-time if any name had a
Hi Artem,
The updated test looks good.
Thanks,
Sean
On 06/26/2015 01:57 PM, Artem Smotrakov wrote:
Hi Sean,
I added new test cases to GenerationTests, please take a look:
http://cr.openjdk.java.net/~asmotrak/8074784/webrev.01/
Artem
On 06/16/2015 07:23 PM, Sean Mullan wrote:
On 05/20/2015
Bug report : https://bugs.openjdk.java.net/browse/JDK-8131665
Simple fix to improve the Error message for this scenario.
diff --git
a/src/java.base/share/classes/sun/security/ssl/HandshakeHash.java
b/src/java.base/share/classes/sun/security/ssl/HandshakeHash.java
--- a/src/java.base/share/cla
Hello,
Please review a test bug fix.
Bug: https://bugs.openjdk.java.net/browse/JDK-8129306
Webrev: http://cr.openjdk.java.net/~kshefov/8129306/webrev.00/
-Konstantin
Looks fine to me.
> On 16 Jul 2015, at 19:08, Konstantin Shefov
> wrote:
>
> Hello,
>
> Please review a test bug fix.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8129306
> Webrev: http://cr.openjdk.java.net/~kshefov/8129306/webrev.00/
>
> -Konstantin
Hi Max,
Good point, please see an updated webrev:
http://cr.openjdk.java.net/~asmotrak/8075297/webrev.01/
Artem
On 07/16/2015 12:57 AM, Weijun Wang wrote:
The logic in RefreshKrb5Config.java is very good. Why not also try
NotRefreshable again after writing the correct krb5.conf in
BogusKDC.j
Looks fine to me.
Thanks,
Xuelei
On 7/17/2015 1:02 AM, Seán Coffey wrote:
> Bug report : https://bugs.openjdk.java.net/browse/JDK-8131665
>
> Simple fix to improve the Error message for this scenario.
>
> diff --git
> a/src/java.base/share/classes/sun/security/ssl/HandshakeHash.java
> b/src/jav
One final point.
You have the timeout set to 5 minutes in
+ * @run main/othervm/timeout=300 BogusKDC
Did you observe the test spending a lot of time? A kerberos client is
designed to timeout after 30 seconds if there is no reply from a KDC but
sometimes it could be very fast if the KDC does
The fix looks fine.
On 16.07.15 0:42, Pete Brunet wrote:
An update is available and mostly changes only the test case,
Bug8151626.java. The other change is to remove jtreg.security.policy.
http://cr.openjdk.java.net/~ptbrunet/JDK-8051626/webrev.01/
Changes:
From Sean
- The jtreg @run statem
>From Mandy:
- remove unused imports
- add @run main/othervm
http://cr.openjdk.java.net/~ptbrunet/JDK-8051626/webrev.02/
On 7/15/15 4:42 PM, Pete Brunet wrote:
> An update is available and mostly changes only the test case,
> Bug8151626.java. The other change is to remove jtreg.security.policy.
Hi Max,
On 07/16/2015 06:19 PM, Weijun Wang wrote:
One final point.
You have the timeout set to 5 minutes in
+ * @run main/othervm/timeout=300 BogusKDC
Did you observe the test spending a lot of time? A kerberos client is
designed to timeout after 30 seconds if there is no reply from a KDC
>>
> I think it it enough to add a "max_retries = 1" to [libdefaults] of
> krb5.conf, and left default timeout value for the test. Please take a look at
> updated webrev:
>
> http://cr.openjdk.java.net/~asmotrak/8075297/webrev.02/
Can you also add the same line to the krb5.conf for the other
13 matches
Mail list logo
