Re: [9] RFR: 8130875 Out of memory when using TLS_RSA_WITH_AES_128_GCM_SHA256

2015-09-03 Thread Anthony Scarpino
> On Sep 2, 2015, at 10:50 PM, Anthony Scarpino > wrote: > > >> On Sep 2, 2015, at 3:45 PM, Valerie Peng wrote: >> >> >> Can someone help review this java workaround for Solaris memory leak bug in >> Ucrypto library? >> Essentially, the memory leak occurs when a null output buffer is speci

RFR 8132082: Let OracleUcrypto accept RSAPrivateKey

2015-09-03 Thread Ivan Gerasimov
Hello! Would you please help review this fix, which adds support for RSAPrivateKey to the OracleUcrypto provider? The fix was provided by Valerie Peng. BUGURL: https://bugs.openjdk.java.net/browse/JDK-8132082 WEBREV: http://cr.openjdk.java.net/~igerasim/8132082/00/webrev/ Sincerely yours, Iv

Re: RFR 8132082: Let OracleUcrypto accept RSAPrivateKey

2015-09-03 Thread Seán Coffey
Looks good to me Ivan. Thanks for handling. Some new exception messages need padding out as per efforts in 8133535 but I'll re-sync/rework my patch once your changes hit the repo. Regards, Sean. On 03/09/2015 16:53, Ivan Gerasimov wrote: Hello! Would you please help review this fix, which a

Re: RFR 8132082: Let OracleUcrypto accept RSAPrivateKey

2015-09-03 Thread Ivan Gerasimov
On 03.09.2015 20:44, Seán Coffey wrote: Looks good to me Ivan. Thanks for handling. Thank you Seán! Some new exception messages need padding out as per efforts in 8133535 but I'll re-sync/rework my patch once your changes hit the repo. Yes, that will be very helpful! Sincerely yours, Iv

Re: [9] RFR: 8130875 Out of memory when using TLS_RSA_WITH_AES_128_GCM_SHA256

2015-09-03 Thread Valerie Peng
Alright, I will update the synopsis. I am not exactly sure if it's GCM only as CipherFinal() call is used for all Ucrypto encryption/decryption. The testcase is using AES/GCM, but I am not sure if the underlying native code which has the problem is GCM specific. The using outLen's reference a

Re: RFR 8056174: New APIs for jar signing

2015-09-03 Thread Sean Mullan
On 09/01/2015 02:50 AM, Weijun Wang wrote: Updated a little: rewrite of jarsigner tool itself using the JarSigner API included. Still at the same URL below. I notice that you don't use the new JarSigner API at all in the jarsigner tool and go straight to the BuilderX/JarSignerX classes. This

Re: [9] RFR: 8130875 Out of memory when using TLS_RSA_WITH_AES_128_GCM_SHA256

2015-09-03 Thread Valerie Peng
For all the JavaCritical calls, it's impossible to have the combination of (bufOut==NULL && outLen!=0) as the outLen value is generated by VM based on bufOut. Anyway, just to play it safe, I added a line to set outLen to 0 just to match what is done for line 657. http://cr.openjdk.java.net/~

Re: RFR 8132082: Let OracleUcrypto accept RSAPrivateKey

2015-09-03 Thread Valerie Peng
Thanks for taking care of this~ Valerie On 9/3/2015 12:33 PM, Ivan Gerasimov wrote: On 03.09.2015 20:44, Seán Coffey wrote: Looks good to me Ivan. Thanks for handling. Thank you Seán! Some new exception messages need padding out as per efforts in 8133535 but I'll re-sync/rework my patch o