[9] request for review: 8136534: Loading JKS keystore using non-null InputStream results in closed stream

Please review this JDK 9 fix to stop KeyStore.load from closing the input stream passed to it. Thanks. Bug: https://bugs.openjdk.java.net/browse/JDK-8136534 Webrev: http://cr.openjdk.java.net/~vinnie/8136534/webrev.00/

Re: [9] request for review: 8136534: Loading JKS keystore using non-null InputStream results in closed stream

Line 257 looks long. Not sure why you changed it. Otherwise, looks good. Brad On 9/16/2015 12:12 PM, Vincent Ryan wrote: Please review this JDK 9 fix to stop KeyStore.load from closing the input stream passed to it. Thanks. Bug: https://bugs.openjdk.java.net/browse/JDK-8136534 Webrev: http

Re: RFR for JDK-8048604 : Tests for strong crypto ciphers

Can u please make sure that all the Cipher objects are retrieved using "SunJCE" provider? I noticed some inconsistencies here and there. - line 94, 'provider' object should be used here. - need @library tag to find the TestUtilities class, otherwise, the compilation fails. - variable "mod

Re: 8136436: jarsigner tests include both a warnings.sh and a warnings subdir

Ping again. > On Sep 14, 2015, at 12:08 PM, Wang Weijun wrote: > > I’ve filed the bug at https://bugs.openjdk.java.net/browse/JDK-8136436. > > jtreg first creates the "warnings" directory to store jtr files of tests in > warnings subdir, and then clean it up and store retained files for > war

Re: 8136436: jarsigner tests include both a warnings.sh and a warnings subdir

Looks fine to me. Xuelei On 9/17/2015 10:06 AM, Wang Weijun wrote: > Ping again. > >> On Sep 14, 2015, at 12:08 PM, Wang Weijun wrote: >> >> I’ve filed the bug at https://bugs.openjdk.java.net/browse/JDK-8136436. >> >> jtreg first creates the "warnings" directory to store jtr files of tests in