Hi All
Please take a look at
http://cr.openjdk.java.net/~weijun/8130132/webrev.00/
These new warnings will be added to jarsigner:
The signer's certificate is self-signed.
This jar contains entries whose signer certificate is self-signed.
The %1$s algorithm used as %2$s is considered a
Hi All
An updated webrev is available at
http://cr.openjdk.java.net/~weijun/8056174/webrev.06/
Compared with webrev.05, these changes are made:
1. In AlgorithmId.java, getDefaultSigAlgForKey() looks at the key size and
returns signature algorithms with different digest part. Thanks, Mike!
2
A few more comments -
The name of the new interface should be SecureRandomParameterSpec
instead of SecureRandomSpec.
The getInstance methods can now take a SecureRandomParameterSpec object
(rather than an AlgorithmParameterSpec). They should throw
InvalidAlgorithmParameterException (not Ille
Looks good, just a couple of minor comments:
In JarSigner.Builder.getDefaultSignatureAlgorithm, change the word
"bigger" to "greater than".
In AlgorithmId.getDefaultSigAlgForKey, I think you can remove the last
sentence ("Remember ...") - this seems like a ToDo note to yourself
which has bee
> On Nov 19, 2015, at 2:40 AM, Sean Mullan wrote:
>
> Looks good, just a couple of minor comments:
>
> In JarSigner.Builder.getDefaultSignatureAlgorithm, change the word "bigger"
> to "greater than".
Updated.
>
> In AlgorithmId.getDefaultSigAlgForKey, I think you can remove the last
> sent
