Re: RFR 8141690: JDK-8133151 change to MakeJavaSecurity.java is not complete

2015-11-24 Thread Magnus Ihse Bursie
On 2015-11-20 02:12, Wang Weijun wrote: Ding dong. Even though this code resides in the make directory, it is not really build code, so I cannot comment on it. /Magnus On Nov 9, 2015, at 3:35 PM, Wang Weijun wrote: Hi All Please review the code change at http://cr.openjdk.java.net/~

Re: RFR 8141457: keytool default cert fingerprint algorithm should be SHA-256

2015-11-24 Thread Sean Mullan
Looks good - although you could replace the MD5 fingerprints with the SHA256 fingerprints in the test files for some additional testing. --Sean On 11/23/2015 08:00 PM, Wang Weijun wrote: Hi All Please review a code change at http://cr.openjdk.java.net/~weijun/8141457/webrev.00/ SHA-256

Re: RFR 8143913: MSCAPI keystore should accept Certificate[] in setEntry()

2015-11-24 Thread Vincent Ryan
Your fix looks good. Thanks. > On 24 Nov 2015, at 14:32, Weijun Wang wrote: > > Please review the fix at > > http://cr.openjdk.java.net/~weijun/8143913/webrev.00/ > > Not everyone passes a X509Certificate[] into KeyStore::setEntry(). > > Thanks > Max

RFR 8143913: MSCAPI keystore should accept Certificate[] in setEntry()

2015-11-24 Thread Weijun Wang
Please review the fix at http://cr.openjdk.java.net/~weijun/8143913/webrev.00/ Not everyone passes a X509Certificate[] into KeyStore::setEntry(). Thanks Max

Re: RFR 8143377: Test PKCS8Test.java fails

2015-11-24 Thread Rajan Halade
Hi Amanda, If you want skip test on solaris, please use - @requires (os.family != "solaris") http://openjdk.java.net/jtreg/tag-spec.html#requires_names Note: I am not a official OpenJDK reviewer. Thanks, Rajan On 11/24/15 2:05 PM, Amanda Jiang wrote: Hi Max, Could you please review the fix

RFR 8143377: Test PKCS8Test.java fails

2015-11-24 Thread Amanda Jiang
Hi Max, Could you please review the fixes below for a test bug? Bug: https://bugs.openjdk.java.net/browse/JDK-8143377 Webrev: http://cr.openjdk.java.net/~amjiang/8143377/webrev/ Thanks, Amanda

Re: RFR 8143377: Test PKCS8Test.java fails

2015-11-24 Thread Rajan Halade
This test was added to ProblemList.txt, please update it to remove the test. - sun/security/pkcs/pkcs8/PKCS8Test.java solaris-all Thanks, Rajan On 11/24/15 3:13 PM, Rajan Halade wrote: Hi Amanda, If you want skip test on solaris, please use - @requires (os.family != "solaris") http://openjd

Re: RFR 8143377: Test PKCS8Test.java fails

2015-11-24 Thread Rajan Halade
Looks good to me, thanks for the updates! Please wait for one official reviewer before you commit. Thanks, Rajan On 11/24/15 3:36 PM, Amanda Jiang wrote: Hi Rajan, Thanks for reviewing, please check the updated changeset: http://cr.openjdk.java.net/~amjiang/8143377/webrev.01/ Thanks, Amanda

Re: RFR 8143377: Test PKCS8Test.java fails

2015-11-24 Thread Amanda Jiang
Hi Rajan, Thanks for reviewing, please check the updated changeset: http://cr.openjdk.java.net/~amjiang/8143377/webrev.01/ Thanks, Amanda On 15/11/24 下午3:26, Rajan Halade wrote: This test was added to ProblemList.txt, please update it to remove the test. - sun/security/pkcs/pkcs8/PKCS8Test

Re: RFR 8143377: Test PKCS8Test.java fails

2015-11-24 Thread Wang Weijun
Done. http://hg.openjdk.java.net/jdk9/dev/jdk/rev/33fd40487d6d Thanks Max > On Nov 25, 2015, at 7:42 AM, Rajan Halade wrote: > > Looks good to me, thanks for the updates! > > Please wait for one official reviewer before you commit. > > Thanks, > Rajan > On 11/24/15 3:36 PM, Amanda Jiang wrote