[xs] RFR: 8146967: [TEST_BUG] javax/security/auth/SubjectDomainCombiner/Optimize.java should use 4-args ProtectionDomain constructor

2016-01-13 Thread Ivan Gerasimov
Hello! Would you please help review the fix that solves the issue spotted when running the test with earlier version of jdk? BUGURL: https://bugs.openjdk.java.net/browse/JDK-8146967 WEBREV: http://cr.openjdk.java.net/~igerasim/8146967/00/webrev/ Sincerely yours, Ivan

Code Review Request 8146669 Test SessionTimeOutTests fails intermittently

2016-01-13 Thread Xuelei Fan
Hi, Please review the intermittently test failure fix. http://cr.openjdk.java.net/~xuelei/8146669/webrev.00/ In the updated test case, an integer (createdPorts) is used to count the server sockets. Every server socket is created in a new thread. The access and update to createdPorts should

Re: RFR 8058778: New APIs for creating certificates and certificate requests

2016-01-13 Thread David M. Lloyd
On 01/12/2016 07:02 PM, Wang Weijun wrote: A new webrev at http://cr.openjdk.java.net/~weijun/8058778/webrev.09/ A couple of questions/comments... +public interface Builder +> { What is the point of the "T" self-type variable? It does not seem to be referenced. Also the

Re: RFR 8058778: New APIs for creating certificates and certificate requests

2016-01-13 Thread Wang Weijun
Hi David > On Jan 13, 2016, at 8:08 PM, David M. Lloyd wrote: > > On 01/12/2016 07:02 PM, Wang Weijun wrote: >> A new webrev at >> >> http://cr.openjdk.java.net/~weijun/8058778/webrev.09/ > > A couple of questions/comments... > >> +public interface Builder >> +> { > > What is

Re: RFR 8058778: New APIs for creating certificates and certificate requests

2016-01-13 Thread David M. Lloyd
On 01/13/2016 07:44 AM, Wang Weijun wrote: Hi David On Jan 13, 2016, at 8:08 PM, David M. Lloyd wrote: On 01/12/2016 07:02 PM, Wang Weijun wrote: A new webrev at http://cr.openjdk.java.net/~weijun/8058778/webrev.09/ A couple of questions/comments... +public interface Builder +

Re: RFR 8058778: New APIs for creating certificates and certificate requests

2016-01-13 Thread Sean Mullan
On 01/12/2016 08:02 PM, Wang Weijun wrote: A new webrev at http://cr.openjdk.java.net/~weijun/8058778/webrev.09/ http://cr.openjdk.java.net/~weijun/8058778/webrev.09/specdiff/java/security/cert/package-summary.html Changes from webrev.08: 1. X509Certificate.Builder addAuthorityKeyIdentifierExt

Re: Design review: JEP 273: DRBG-Based SecureRandom Implementations

2016-01-13 Thread Wang Weijun
There's been a long time, the current status is http://cr.openjdk.java.net/~weijun/8051408/webrev.03/ http://cr.openjdk.java.net/~weijun/8051408/webrev.03/specdiff/java/security/package-summary.html Two main changes: 1. s/EntropyInput/EntropySource/g. 2. Two methods in EntropySource, getFullEnt