Re: Code Review Request 8149017 Delayed provider selection broken in RSA client key exchange

2016-03-15 Thread Xuelei Fan
Ping ... On 3/10/2016 11:50 PM, Xuelei Fan wrote: > Hi, > > Please review this update: > >http://cr.openjdk.java.net/~xuelei/8149017/webrev.00/ > > The problem is that calling Cipher.getProvider, or any method on Cipher, > forces the Cipher instance to skip the delayed provider selection wh

RE: [9] RFR: 8150512:Update test for jdk.security.provider.preferred security property.

2016-03-15 Thread Sibabrata Sahoo
Hi Anthony, Please find the updated webrev: http://cr.openjdk.java.net/~ssahoo/8150512/webrev.01/ Following comments associated. Thanks, Siba --- Here are my comments... - PreferredProviderTest.java:62-70 You appear to be missing SHA1 and SHA-224. They should be added to the

Re: Code Review Request 8149017 Delayed provider selection broken inRSA client key exchange

2016-03-15 Thread Bernd Eckenfels
BTW, the System.out is already in the existing code, but I wonder if this should use Debug.println instead? Gruss Bernd -- http://bernd.eckenfels.net Von: Xuelei Fan Gesendet: Dienstag, 15. März 2016 11:02 An: OpenJDK Betreff: Re: Code Review Request 8149017 Delayed provider selection broken

Re: Code Review Request 8149017 Delayed provider selection broken inRSA client key exchange

2016-03-15 Thread Xuelei Fan
On 3/15/2016 6:29 PM, Bernd Eckenfels wrote: > > > BTW, the System.out is already in the existing code, but I wonder if > this should use Debug.println instead? > Better to use Debug.println(). I will make the update in an separate debug log improvement enhancement. Thanks, Xuelei > > > G

Regarding JDK-8149169 - SSLSocketInputRecord.decodeInputRecord buffer overflow

2016-03-15 Thread Langer, Christoph
Hi there, today I did some debugging regarding the TLS exception I've seen and reported in JDK-8149169: javax.net.ssl.SSLException: java.nio.BufferOverflowException at sun.security.ssl.Alerts.getSSLException(Alerts.java:214) at sun.security.ssl.SSLSocketImpl.fatal(SSLSocketIm

Re: [9] RFR: 8151734: Mark Unreachable.java and MaxRetries.java as intermittently failing

2016-03-15 Thread Weijun Wang
Hi Artem I thought I replied to this but seems haven't. Yes, the change looks fine. Thanks Max On 3/12/2016 6:07, Artem Smotrakov wrote: Hello, The following krb5 tests have been observed to intermittently fail: sun/security/krb5/auto/Unreachable.java sun/security/krb5/auto/MaxRetries.java