Ping again. No comment?
--Max
> On Mar 21, 2016, at 1:15 PM, Wang Weijun wrote:
>
> Hi All
>
> Please take a review at the design and implementation of DRBG at:
>
> http://cr.openjdk.java.net/~weijun/8051408/webrev.07
> http://cr.openjdk.java.net/~weijun/8051408/webrev.07/spec
> http://cr.ope
Hi Anthony, Vladimir,
thanks for your evaluation. Should I open a new bug for the change in
AESCrypt or can we do it under the same bug id like the ppc-specific
AES intrinisc (i.e. "8152172: PPC64: Support AES intrinsics") ?
I also think that the AESCrypt::sessionK type change change, although
it
It could be done under the same bug id 8152172. It will be clear why we did
that.
Regards,
Vladimir
On 3/29/16 6:05 AM, Volker Simonis wrote:
Hi Anthony, Vladimir,
thanks for your evaluation. Should I open a new bug for the change in
AESCrypt or can we do it under the same bug id like the ppc
Hi, Tony,
- line 243, 'be' should be "by"?
- line 271, why use SESSION_MAX - 1 instead of just SESSION_MAX? The
check on line 286 make sure that the queue will not be empty. Actually,
the comment has "until only one is left", but the condition is ">1", so
shouldn't it be "until 2 left"? This
Hi Mandy,
On 3/28/2016 8:48 PM, Mandy Chung wrote:
On Mar 28, 2016, at 5:03 PM, Joseph D. Darcy wrote:
Hello,
New iteration of the webrev updated after the Jigsaw integration and
incorporating the earlier feedback.
http://cr.openjdk.java.net/~darcy/8151763.1
# tools/jimage/JImageTest.
> On Mar 29, 2016, at 12:15 PM, joe darcy wrote:
>
> Hi Mandy,
>
> On 3/28/2016 8:48 PM, Mandy Chung wrote:
>>> On Mar 28, 2016, at 5:03 PM, Joseph D. Darcy wrote:
>>>
>>> Hello,
>>>
>>> New iteration of the webrev updated after the Jigsaw integration and
>>> incorporating the earlier feedb
Volker,
Changing this with your other changes in hs-comp repo is best.. Just let
me know when you are ready for code review on this piece.
thanks
Tony
On 03/29/2016 06:05 AM, Volker Simonis wrote:
Hi Anthony, Vladimir,
thanks for your evaluation. Should I open a new bug for the change in
