RFR of JDK-8153239: ProblemList update for sun/security/provider/NSASuiteB/TestDSAGenParameterSpec.java

2016-04-01 Thread John Jiang
Hi, Because of JDK-8137255, it needs to add test sun/security/provider/NSASuiteB/TestDSAGenParameterSpec.java to ProblemList. Issue: https://bugs.openjdk.java.net/browse/JDK-8153239 Webrev: http://cr.openjdk.java.net/~jjiang/8153239/webrev.00 Patch: --- a/test/ProblemList.txt Fri Apr 01 1

Re: RFR 6483657: MSCAPI provider does not create unique alias names

2016-04-01 Thread Vincent Ryan
Your fix looks good. Thanks. > On 31 Mar 2016, at 16:57, Ivan Gerasimov wrote: > > Hello! > > Could you please help review the fix for this long standing issue? > Windows-MY allows non-unique aliases, but our implementation of KeyStore does > not take it into account. > > To help to deal with

Re: RFR 8051408: JEP 273: DRBG-Based SecureRandom Implementations

2016-04-01 Thread Wang Weijun
Hi All Updated webrev at http://cr.openjdk.java.net/~weijun/8051408/webrev.08/ http://cr.openjdk.java.net/~weijun/8051408/webrev.08/spec http://cr.openjdk.java.net/~weijun/8051408/webrev.08/specdiff Spec changes: - More text in @implNote of DrbgParameters.java, which somehow matches the

Code Review Request 8072452 Support DHE sizes up to 8192-bits

2016-04-01 Thread Xuelei Fan
Hi, Please review this improvement update to support DHE sizes up to 8192-bits and DSA sizes up to 3072-bits: http://cr.openjdk.java.net/~xuelei/8072452/webrev.00 This updated extends to support 3072-bits DH and DSA parameters generation, and pre-computed DH parameters up to 8192 bits and

Re: RFR 8098580: drainRefQueueBounds() puts pressure on pool.size()

2016-04-01 Thread Anthony Scarpino
I updated the webrev: http://cr.openjdk.java.net/~ascarpino/8098580/webrev.01/ Comments below On 03/29/2016 11:08 AM, Valerie Peng wrote: Hi, Tony, - line 243, 'be' should be "by"? Yes, by. - line 271, why use SESSION_MAX - 1 instead of just SESSION_MAX? The check on line 286 make sur

Re: Code Review Request 8072452 Support DHE sizes up to 8192-bits

2016-04-01 Thread Bernd Eckenfels
Hello Xuelei, glad to see this. :) --java.base/share/classes/sun/security/ssl/DHCrypt.java Does the comment "// FEDHE" stand for FFDHE (JDK-8140436)? maybe name the variables ffdhe instead of p? (they might be directly used clients to verify well known parameters) Unrelated to the ch