Re: RFR of JDK-8153239: ProblemList update for sun/security/provider/NSASuiteB/TestDSAGenParameterSpec.java

2016-04-06 Thread John Jiang
Hi, This test failed several times, and it's better to put it to ProblemList until the issue is resolved. Please review this patch, thanks! Best regards, John Jiang On 2016/4/1 15:58, John Jiang wrote: Hi, Because of JDK-8137255, it needs to add test sun/security/provider/NSASuiteB/TestDSAGe

Re: RFR of JDK-8153239: ProblemList update for sun/security/provider/NSASuiteB/TestDSAGenParameterSpec.java

2016-04-06 Thread Xuelei Fan
Looks fine to me. Xuelei On 4/6/2016 9:04 PM, John Jiang wrote: > Hi, > This test failed several times, and it's better to put it to ProblemList > until the issue is resolved. > Please review this patch, thanks! > > Best regards, > John Jiang > > On 2016/4/1 15:58, John Jiang wrote: >> Hi, >> B

RFR: draft-ietf-kitten-rfc5653bis-03 JGSS-API

2016-04-06 Thread Wang Weijun
I just posted a new version of rfc5653bis. The major changes in this I-D (compared to RFC 5653) are: 1. public byte[] GSSException#getOutputToken(). If initSecContext or acceptSecContext fail, the exception could contain a token that can be sent to the peer. For kerberos 5, this is normally a K

RFR 8152205: jdk.security.provider.preferred is ambiguously documented

2016-04-06 Thread Anthony Scarpino
I need a review of this very simple doc clarification. Calling out jdk.security.provider.preferred as a "security property" instead of just a "property". http://cr.openjdk.java.net/~ascarpino/8152205/webrev/ thanks. Tony

Re: RFR 8152205: jdk.security.provider.preferred is ambiguously documented

2016-04-06 Thread Xuelei Fan
Looks fine to me. Xuelei On 4/7/2016 5:23 AM, Anthony Scarpino wrote: > I need a review of this very simple doc clarification. Calling out > jdk.security.provider.preferred as a "security property" instead of just > a "property". > > http://cr.openjdk.java.net/~ascarpino/8152205/webrev/ > > th

Re: Code Review Request 8144566, Custom HostnameVerifier disables SNI extension

2016-04-06 Thread Xuelei Fan
Ping ... On 1/20/2016 9:14 AM, Xuelei Fan wrote: > Ping ... > > On 12/8/2015 8:12 PM, Xuelei Fan wrote: >> Good catch! >> >> I copied the comment here: >> >> -- >> SocketFactory sslsf = SSLSocketFactory.getDefault(); >> SSLSocket ssls = (SSLSocket) sslsf.createSocket(); >> s

Re: RFR 8152205: jdk.security.provider.preferred is ambiguously documented

2016-04-06 Thread Bradford Wetmore
If I was doing this from scratch, I would probably capitalize it to indicate it's a java.security.Security property and add inside the @code. {@code jdk.security.provider.preferred} security -> {@code jdk.security.provider.preferred Security} But I see it done that way in other places, so this

Re: RFR 8152205: jdk.security.provider.preferred is ambiguously documented

2016-04-06 Thread Wang Weijun
In my DRBG changeset, I use this style: {@code jdk.security.provider.preferred} {@linkplain Security#getProperty(String) security property} --Max > On Apr 7, 2016, at 8:23 AM, Bradford Wetmore > wrote: > > If I was doing this from scratch, I would probably capitalize it to indicate > it's

JDK 9 RFR of JDK-8153695: Problem list sun/security/pkcs11/Provider/Login.sh for linux-all

2016-04-06 Thread Amy Lu
sun/security/pkcs11/Provider/Login.sh This test is known to fail at Linux platform (JDK-8153545). Please review the patch to put the test to ProblemList.txt for linux-all until mentioned issue (JDK-8153545) is resolved. Tested with jtreg -listtests bug: https://bugs.openjdk.java.net/browse/JDK

Re: JDK 9 RFR of JDK-8153695: Problem list sun/security/pkcs11/Provider/Login.sh for linux-all

2016-04-06 Thread Vincent Ryan
That looks fine to me. Thanks. > On 7 Apr 2016, at 04:42, Amy Lu wrote: > > sun/security/pkcs11/Provider/Login.sh > This test is known to fail at Linux platform (JDK-8153545). > > Please review the patch to put the test to ProblemList.txt for linux-all > until mentioned issue (JDK-8153545) i