Re: [9] RFR:JDK-8143305:sun/security/ec/TestEC.java fails intermittently

Thanks Sean and Xuelei I filed new bug for adding debug option,see https://bugs.openjdk.java.net/browse/JDK-8158620 The codes were also updated follow Sean's suggestion at here: http://cr.openjdk.java.net/~tidu/8158620/webrev.00/ Please help to review again.Thanks. Regards Tim On 2016/6/3 4:3

Re: [9] RFR:JDK-8143305:sun/security/ec/TestEC.java fails intermittently

Looks fine to me. Thanks, Xuelei On 6/3/2016 3:52 PM, Tim Du wrote: > Thanks Sean and Xuelei > > I filed new bug for adding debug option,see > https://bugs.openjdk.java.net/browse/JDK-8158620 > The codes were also updated follow Sean's suggestion at here: > http://cr.openjdk.java.net/~tidu/81586

Re: [9] RFR:JDK-8143305:sun/security/ec/TestEC.java fails intermittently

A small nit, but the debug field should be private (and final for good measure). I know this is just a test and it doesn't expose a security issue, but I think it is good practice to adhere to secure programming conventions even when writing tests. This field is only used within the test, so it

Re: RFR 8157308: DRBG serialization fix

On 06/03/2016 02:12 AM, Wang Weijun wrote: Webrev updated at http://cr.openjdk.java.net/~weijun/8157308/webrev.01/ AbstractDrbg is an internal class so I have to patch the JDK itself. Hmm, ok, but why didn't you need to do that for the previous version of this test? --Sean Thanks Max

Re: RFR 8157308: DRBG serialization fix

> On Jun 3, 2016, at 10:02 PM, Sean Mullan wrote: > > On 06/03/2016 02:12 AM, Wang Weijun wrote: >> Webrev updated at >> >> http://cr.openjdk.java.net/~weijun/8157308/webrev.01/ >> >> AbstractDrbg is an internal class so I have to patch the JDK itself. > > Hmm, ok, but why didn't you need t

RFR: 8157603 TestCipher.java doesn't check one of the decrypted message as expected

Could you please review the proposed fix for regression test BUGURL: https://bugs.openjdk.java.net/browse/JDK-8157603 WEBREV: http://cr.openjdk.java.net/~akosarev/8157603/webrev.00 DESCRIPTION: **Main problem is that we were not perfo

Re: RFR 8157308: DRBG serialization fix

On 06/03/2016 10:13 AM, Wang Weijun wrote: On Jun 3, 2016, at 10:02 PM, Sean Mullan wrote: On 06/03/2016 02:12 AM, Wang Weijun wrote: Webrev updated at http://cr.openjdk.java.net/~weijun/8157308/webrev.01/ AbstractDrbg is an internal class so I have to patch the JDK itself. Hmm, ok, b

Re: Query - Does JSSE library implement the Ciphers or Algorithms of a SSL protocol ?

Hi Brad, Thanks for sending me the link. I had just started going through the JCA document but did not finish reading the doc when i asked my original question :-). I will go through these docs in detail. I saw this line *"Cryptographic implementations in the JDK are distributed through several d

Re: RFR: 8157603 TestCipher.java doesn't check one of the decrypted message as expected

Changes look fine. Thanks, Valerie On 6/3/2016 8:57 AM, Artem Kosarev wrote: Could you please review the proposed fix for regression test BUGURL: https://bugs.openjdk.java.net/browse/JDK-8157603 WEBREV: http://cr.openjdk.java.net/~akosarev/8157603/webrev.00 DESCRIPTION: **Main problem is tha

Re: [9] RFR: 8157896: TestDSAGenParameterSpec.java test fails with timeout

SupportedDSAParamGen.java = Please use more large timeout. The update from 450 to 550 may be not significant enough to prevent intermittent failure. I may use bigger value, 600 or even bigger? The same comment for TestDSAGenParameterSpec.java. Thanks, Xuelei On 5/31/201