[9] RFR: 8152745: javax/net/ssl/TLS/TestJSSE.java fails intermittently: Unsupported or unrecognized SSL message

2016-06-21 Thread Artem Smotrakov
Hello, Please review the patch below for javax/net/ssl/TLS/TestJSSE.java test. The test has been observed to fail intermittently with "Unsupported or unrecognized SSL" error. But I couldn't reproduce it manually while running the test in a loop for a couple of days on Linux x64. For now it's

Re: RFR: 8155039: Simplify code to setup SSLContextImpl and TrustManagerFactoryImpl

2016-06-21 Thread Claes Redestad
After some internal discussions: http://cr.openjdk.java.net/~redestad/8155039/webrev.03/ Drops the PropertiesWrapper and Properties-retrieving approach in favor of a getter to retrieve multiple properties into a Map. /Claes On 2016-06-10 20:13, Mandy Chung wrote: On Jun 10, 2016, at 4:33 AM

Re: [9] RFR: 8074580: sun/security/pkcs11/rsa/TestKeyPairGenerator.java fails due to PKCS11Exception: CKR_FUNCTION_FAILED

2016-06-21 Thread Artem Smotrakov
I forgot to include PKCS11.java to webrev, here is an updated webrev http://cr.openjdk.java.net/~asmotrak/8074580/webrev.01/ Artem On 06/20/2016 11:12 AM, Artem Smotrakov wrote: Hello, Please review the following patch below for 9. TestKeyPairGenerator.java test intermittently fails with CK

Re: [9] RFR: 8152745: javax/net/ssl/TLS/TestJSSE.java fails intermittently: Unsupported or unrecognized SSL message

2016-06-21 Thread Xuelei Fan
Looks more like a issue of "Unsupported or unrecognized SSL message". This issue might be impacted by other test cases that running in the same time that using free socket port. It's good to dump the SSL/TLS record for further evaluation. Minor comments: test/javax/net/ssl/TLS/TestJSSE.java 36

Re: [9] RFR: 8152745: javax/net/ssl/TLS/TestJSSE.java fails intermittently: Unsupported or unrecognized SSL message

2016-06-21 Thread Artem Smotrakov
Hi Xuelei, Thank you for review. Please see inline. On 06/21/2016 05:57 PM, Xuelei Fan wrote: Looks more like a issue of "Unsupported or unrecognized SSL message". This issue might be impacted by other test cases that running in the same time that using free socket port. It's good to dump the

Re: [9] RFR: 8152745: javax/net/ssl/TLS/TestJSSE.java fails intermittently: Unsupported or unrecognized SSL message

2016-06-21 Thread Xuelei Fan
looks fine to me. Thanks, Xuelei On 6/22/2016 9:35 AM, Artem Smotrakov wrote: > Hi Xuelei, > > Thank you for review. Please see inline. > > On 06/21/2016 05:57 PM, Xuelei Fan wrote: >> Looks more like a issue of "Unsupported or unrecognized SSL message". >> This issue might be impacted by other

[9] RFR 8146393:sun/security/tools/jarsigner/ts.sh failed on OEL Linux 7 with ar_SA Locale

2016-06-21 Thread Tim Du
Hi, Would you please review the path for following bug? bug: https://bugs.openjdk.java.net/browse/JDK-8146393 webrev: http://cr.openjdk.java.net/~tidu/8146393/webrev.00/ The test failed when using String.format() to format the server port on ar_SA Locale, Adding Locale.ROOT arguments to avoid