RFR 8163303: Remove identity scope information from jarsigner -verbose output

2016-08-08 Thread Weijun Wang
Hi All Please review the code change at http://cr.openjdk.java.net/~weijun/8163303/webrev.00 I removed the "@SuppressWarnings("deprecation")" at the beginning. I think this has been unnecessary for quite a while since calls to deprecated classes (ContentSigner and ContentSignerParameters)

Re: RFR 8163303: Remove identity scope information from jarsigner -verbose output

2016-08-08 Thread Sean Mullan
Looks good to me. You will need to add an appropriate noreg label to the bug. --Sean On 08/08/2016 03:28 AM, Weijun Wang wrote: Hi All Please review the code change at http://cr.openjdk.java.net/~weijun/8163303/webrev.00 I removed the "@SuppressWarnings("deprecation")" at the beginning.

Re: RFR 8163303: Remove identity scope information from jarsigner -verbose output

2016-08-08 Thread Weijun Wang
Thanks. I'll add noreg-cleanup. --Max On 8/8/2016 21:33, Sean Mullan wrote: Looks good to me. You will need to add an appropriate noreg label to the bug. --Sean On 08/08/2016 03:28 AM, Weijun Wang wrote: Hi All Please review the code change at http://cr.openjdk.java.net/~weijun/8163303/

RFR 8162739: Create new keytool option to access cacerts file

2016-08-08 Thread Weijun Wang
Please review the code changes at http://cr.openjdk.java.net/~weijun/8162739/webrev.00/ A new -cacerts option is added to keytool so there is no need to provide the full cacerts path on the command line. lib/security/cacerts is considered an implementation detail and subject to change. Th

Re: RFR 8162739: Create new keytool option to access cacerts file

2016-08-08 Thread Erik Joelsson
Build change looks fine. /Erik On 2016-08-08 15:46, Weijun Wang wrote: Please review the code changes at http://cr.openjdk.java.net/~weijun/8162739/webrev.00/ A new -cacerts option is added to keytool so there is no need to provide the full cacerts path on the command line. lib/security

Re: RFR 8162739: Create new keytool option to access cacerts file

2016-08-08 Thread Vincent Ryan
Your changes look good to me. Thanks. > On 8 Aug 2016, at 14:46, Weijun Wang wrote: > > Please review the code changes at > > http://cr.openjdk.java.net/~weijun/8162739/webrev.00/ > > A new -cacerts option is added to keytool so there is no need to provide the > full cacerts path on the co

[Update] RFR 8132943: ServerHandshaker may select non-empty OCSPStatusRequest structures when Responder ID selection is not supported

2016-08-08 Thread Jamil Nimeh
Hello all, this update removes an unnecessary change in test/javax/net/ssl, adds in some additional logging, and an early exit condition from the loop if an acceptable status_request_v2 item is found (favoring OCSP_MULTI over OCSP). Also an additional test case that exercises this exit conditi

Re: [9] RFR 8154113: java.security.AccessControlException: access denied ("java.security.SecurityPermission" "authProvider.SunMSCAPI")

2016-08-08 Thread Valerie Peng
Thanks for the comment, I made the updates and will verify with JPRT. Valerie On 8/4/2016 9:07 PM, Mandy Chung wrote: On Aug 4, 2016, at 7:20 AM, Sean Mullan wrote: On 08/04/2016 12:42 AM, Mandy Chung wrote: A passing comment: The test can simply specify @modules jdk.crypto.mscapi and this

RE: [9] RFR: 8159964: Update Tests to verify JDK build for "JDK-8159488 Deprivilege java.xml.crypto"

2016-08-08 Thread Sibabrata Sahoo
Ping.. -Original Message- From: Sibabrata Sahoo Sent: Friday, August 05, 2016 7:28 PM To: Weijun Wang; security-dev@openjdk.java.net; Valerie Peng Subject: RE: [9] RFR: 8159964: Update Tests to verify JDK build for "JDK-8159488 Deprivilege java.xml.crypto" Hi Max, Here is the updated w

[9]RFR 8163435: Update issue number for SupportedDHKeys.java and UnsupportedDHKeys.java in ProblemList

2016-08-08 Thread John Jiang
Hi, In ProblemList.txt, the tests sun/security/pkcs11/KeyAgreement/SupportedDHKeys.java and sun/security/pkcs11/KeyAgreement/UnsupportedDHKeys.java are tracked by 8154910. However, JDK-8154910 had been closed as the duplicate of JDK-8077138. So, it has to associate both of the above tests to