On 8/25/2016 2:06 PM, Weijun Wang wrote:
I think Artem is correct here.
All those tests that modify static fields should run in othervm mode, so
that *each* runs in its *own* VM. All other tests, which make no such
modifications, can share the *same* VM using agentvm.
It's too strong to follow
On 08/24/2016 10:25 PM, Xuelei Fan wrote:
On 8/25/2016 7:57 AM, Sean Mullan wrote:
I posted an updated webrev:
http://cr.openjdk.java.net/~mullan/webrevs/8151893/webrev.0
I guess the link should be:
http://cr.openjdk.java.net/~mullan/webrevs/8151893/webrev.01/
Yes, thanks.
--Sean
Xuelei
>> http://cr.openjdk.java.net/~mullan/webrevs/8151893/webrev.01/
Looks fine to me except the following minor comment.
java.security
-
818 # AlgConstraint
819 # "disallowAlg" Uri
...
829 # For AlgConstraint, Uri is the algorithm URI String that is not
allowed.
The "disa
Looks good Brad. One comment :
You might hit an NPE here but I guess the Exception handling in the
parent call would handle it :
JceSecurity.java :
254 if (Paths.get(cryptoPolicyProperty).getNameCount() != 1) {
Maybe add a null check to be cleaner ?
I missed the "crypto.policy=crypt
On 08/25/2016 09:47 AM, Xuelei Fan wrote:
http://cr.openjdk.java.net/~mullan/webrevs/8151893/webrev.01/
Looks fine to me except the following minor comment.
java.security
-
818 # AlgConstraint
819 # "disallowAlg" Uri
...
829 # For AlgConstraint, Uri is the algorithm URI
On 8/25/2016 10:14 PM, Sean Mullan wrote:
On 08/25/2016 09:47 AM, Xuelei Fan wrote:
http://cr.openjdk.java.net/~mullan/webrevs/8151893/webrev.01/
Looks fine to me except the following minor comment.
java.security
-
818 # AlgConstraint
819 # "disallowAlg" Uri
...
829 #
I prefer Locale.ROOT now.
--Max
On 8/25/2016 22:14, Sean Mullan wrote:
103 disallowedRefUriSchemes.add(scheme.toLowerCase());
Better to use toLowerCase(Locale.ENGLISH). There are issues to use
toUpperCase/toLowerCase when comparing two case-insensitive strings. See
JDK-6972387.
Ok.
The
Hi Artem, Xuelei,
thank you for your comments. Please see inline.
On 25.08.2016 4:10, Xuelei Fan wrote:
On 8/25/2016 3:55 AM, Artem Smotrakov wrote:
Hi Svetlana,
Thank you for cleaning up this test. I have a couple of comments (mostly
about the original test).
1. I see that the test tries
Just a quick reply.
1. The close is necessary.
2. Run in othervm is safer. Please see my comments in other replies.
If you still have questions, I will reply with more details tomorrow when I
work on a PC.
Xuelei
> On Aug 25, 2016, at 11:00 PM, Svetlana Nikandrova
> wrote:
>
> Hi Artem,
Hi Xuelei,
I am not sure why you think it's too strong to follow to it. To me it's
pretty easy to see if a test calls System.setProperty() or
Security.setProperty() methods which modify default JSSE configuration.
Is there any other way to modify default JSSE configuration, so that it
can't
> On Aug 26, 2016, at 12:43 AM, Artem Smotrakov
> wrote:
>
> Hi Xuelei,
>
> I am not sure why you think it's too strong to follow to it. To me it's
> pretty easy to see if a test calls System.setProperty() or
> Security.setProperty() methods which modify default JSSE configuration.
>
> Is
Hi Xuelei,
On 08/25/2016 10:26 AM, Xuelei Fan wrote:
On Aug 26, 2016, at 12:43 AM, Artem Smotrakov
wrote:
Hi Xuelei,
I am not sure why you think it's too strong to follow to it. To me it's pretty
easy to see if a test calls System.setProperty() or Security.setProperty()
methods which mo
> On Aug 26, 2016, at 1:33 AM, Artem Smotrakov
> wrote:
>
> Hi Xuelei,
>
>
>> On 08/25/2016 10:26 AM, Xuelei Fan wrote:
>>
>>> On Aug 26, 2016, at 12:43 AM, Artem Smotrakov
>>> wrote:
>>>
>>> Hi Xuelei,
>>>
>>> I am not sure why you think it's too strong to follow to it. To me it's
>>>
Sure Xuelei, I read
https://docs.oracle.com/javase/8/docs/technotes/guides/security/jsse/JSSERefGuide.html#InstallationAndCustomization
If I understand correctly, the most settings can be done via
system/security properties. But there may be some other ways like
setDefaultHostnameVerifier(), s
Real trivial fix, just updating obsolete bug URLs in code comments.
bug: https://bugs.openjdk.java.net/browse/JDK-8150158
$ hg diff --nodates -a -U 1
diff -r 9c7eb3e1799f
src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/algorithms/implementations/IntegrityHmac.java
---
Looks fine to me.
Tony
On 08/25/2016 12:55 PM, Sean Mullan wrote:
Real trivial fix, just updating obsolete bug URLs in code comments.
bug: https://bugs.openjdk.java.net/browse/JDK-8150158
$ hg diff --nodates -a -U 1
diff -r 9c7eb3e1799f
src/java.xml.crypto/share/classes/com/sun/org/apache/xml
Hi,
Can I get a review of this change to remove the warning suppression and
fix the minor compiler issues that it was hiding in the pkcs11 wrapper
library.
http://cr.openjdk.java.net/~ascarpino/8074838/webrev/
thanks
Tony
Last call:
http://cr.openjdk.java.net/~wetmore/8061842/webrev.03/
Changes from .02:
added null check for cryptoPolicyProperty
renamed javaHomePolicyPath
tweaked exception wording "files in"
added test for empty string ("").
On 8/24/2016 6:22 PM, Weijun Wang wrote:
+Path javaHomeP
Looks ok to me...
I had to look at the C declaration one twice. Too much Java, not enough
C lately.
Brad
On 8/25/2016 2:20 PM, Anthony Scarpino wrote:
Hi,
Can I get a review of this change to remove the warning suppression and
fix the minor compiler issues that it was hiding in the pkcs1
Can you add a new @run line which is the getNameCount()==1 but
getParent() != policyPath case?
+ * @run main/othervm TestUnlimited /unlimited exception
No other comment.
On 8/26/2016 6:56, Bradford Wetmore wrote:
Last call:
http://cr.openjdk.java.net/~wetmore/8061842/webrev.03/
Thanks S
On 8/26/2016 2:52, Artem Smotrakov wrote:
My point is that it's better to run tests which don't modify the default
JSSE configuration in agent VM. It would speed up test execution.
Another benefit of this is that if the test still fails it might reveal
a real bug.
--Max
21 matches
Mail list logo
