Hi All:
Would you help to review the patch for sun/security/pkcs11/PKCS11Test.java?
The test keep pass on not supported platforms, it will make nobody
notice the test was skipped,which is not our expected. Update case to
show failure, when platform not supported. And add the support for
Linux
I think, it is the expected behavior to ignore the test if a platform
does not support it. If showing failures, every testing on unsupported
platform will fail, and additional effort MUST be paid to evaluate the
root cause of the failure. We should try to avoid that.
Xuelei
On 9/27/2016 6:3
Hello team,
This is re-request for review.
20.09.16 16:32, Sergei Kovalev wrote:
Hello team,
Please review very small fix for several regression tests.
BugID: https://bugs.openjdk.java.net/browse/JDK-8166378
WebReview: http://cr.openjdk.java.net/~skovalev/8166378/webrev.00
Issue: The tests
Looks fine to me.
Xuelei
On 9/20/2016 9:32 PM, Sergei Kovalev wrote:
Hello team,
Please review very small fix for several regression tests.
BugID: https://bugs.openjdk.java.net/browse/JDK-8166378
WebReview: http://cr.openjdk.java.net/~skovalev/8166378/webrev.00
Issue: The tests has no declar
Looking at the webrev, it looks we've never tested on "Linux-arm-32" and
"Linux-aarch64-64" before and we only realized it now. This is a true problem.
On the other hand, I also agree with Xuelei's concern. If a new platform is
added and it does not have NSS libs tests will fail.
How about this
(cc'ing Denis who reported the bug)
I think making PKCS11 tests fail on unexpected platform would be helpful
for people who port JDK on new platforms and run tests on them.
Currently the tests silently quit which looks like they pass. This makes
people think that everything went smoothly, but
I think it makes sense to error out on unknown platforms.
This doesn't conflict with skipping tests (or silently passing) for
unsupported platforms.
We just need a way to distinguish them. I'd probably go for the same
approach that Max suggested, i.e. add the list of (known) unsupported
platfor
On 9/28/2016 2:02 AM, Artem Smotrakov wrote:
Currently the tests silently quit which looks like they pass. This makes
people think that everything went smoothly, but actually nothing was
tested.
I did not get the idea. Looks like, if no NSS installed, the test would
be ignored; if NSS get inst
> On Sep 28, 2016, at 7:59 AM, Xuelei Fan wrote:
>
>> Currently the tests silently quit which looks like they pass. This makes
>> people think that everything went smoothly, but actually nothing was
>> tested.
>>
> I did not get the idea.
I think what Artem meant is that without the platform n
Right, thank you Max.
Currently PKCS11 tests are seen as passed on unsupported (by the tests)
platforms, but actually nothing was tested. We'd better know about it.
Artem
On 09/27/2016 05:04 PM, Wang Weijun wrote:
On Sep 28, 2016, at 7:59 AM, Xuelei Fan wrote:
Currently the tests silentl
I agree with the update for that part to add new items. But please
don't throw exception if NSS libs was not found (that's another part of
the fix).
Xuelei
On 9/28/2016 8:22 AM, Artem Smotrakov wrote:
Right, thank you Max.
Currently PKCS11 tests are seen as passed on unsupported (by the tes
11 matches
Mail list logo
