Looks fine to me.
Xuelei
On 10/21/2016 1:13 PM, John Jiang wrote:
Hi,
Please review this patch for fixing an intermittent issue on test
sun/security/ssl/ServerHandshaker/AnonCipherWithWantClientAuth.java.
The fix applies the pattern from
test/javax/net/ssl/templates/SSLSocketSample.java
Webrev
Hello!
A compilation issue with the regression test was observed due to
ambiguity between two X509ExtendedTrustManager classes.
The fix is to organize the imports.
BUGURL: https://bugs.openjdk.java.net/browse/JDK-8168468
WEBREV: http://cr.openjdk.java.net/~igerasim/8168468/00/webrev/
Would y
Looks good. Add noreg-self label to the bug.
--Sean
On 10/21/2016 05:37 AM, Ivan Gerasimov wrote:
Hello!
A compilation issue with the regression test was observed due to
ambiguity between two X509ExtendedTrustManager classes.
The fix is to organize the imports.
BUGURL: https://bugs.openjdk.j
Thank you Sean!
However, my initial evaluation occurred to be wrong: the failure was due
to a different reason, so I reassigned the bug.
With kind regards,
Ivan
On 21.10.2016 14:34, Sean Mullan wrote:
Looks good. Add noreg-self label to the bug.
--Sean
On 10/21/2016 05:37 AM, Ivan Gerasimo
Looks good to me.
Mandy
> On Oct 20, 2016, at 8:22 AM, Sean Mullan wrote:
>
> Please review this change to tighten or remove unnecessary permissions
> granted to the jdk.crypto.pkcs11 module:
>
> http://cr.openjdk.java.net/~mullan/webrevs/8168313/webrev.00/
> https://bugs.openjdk.java.net/bro
Hi John,
It may be better to use SSLTest.java to avoid duplicate code. The class
basically contains parts of SSLSocketSample.java
http://hg.openjdk.java.net/jdk9/dev/jdk/file/0fb9ba19a63a/test/javax/net/ssl/templates/SSLTest.java
Here is an example
http://hg.openjdk.java.net/jdk9/dev/jdk/fil
Hi Bradley,
Thanks for filing the bug, and coming up with a potential patch for the
issue. The bug has just made its way into our system, so we have not
looked at it in detail yet, but in the meantime I added a link to your
post as a comment. You can see the bug here:
https://bugs.openjdk.jav
Hello!
Could someone with the Reviewer's rights please help review and approve
this fix?
The latest webrev can be found here:
http://cr.openjdk.java.net/~igerasim/8165463/01/webrev/
Thanks in advance,
Ivan
Your fix looks good Ivan.
Thanks.
> On 21 Oct 2016, at 22:06, Ivan Gerasimov wrote:
>
> Hello!
>
> Could someone with the Reviewer's rights please help review and approve this
> fix?
>
> The latest webrev can be found here:
> http://cr.openjdk.java.net/~igerasim/8165463/01/webrev/
>
> Thank
