Re: RFR 8075618: Create tests to check jarsigner work with multi-version jar

You can use http://hg.openjdk.java.net/jdk9/dev/jdk/file/d4d7f1f0d688/test/lib/security/SecurityTools.java which would simplify the code. This lib was added to be used in such tests. Note that SecurityTools addresses a couple of known issues with running security tools on machines with

Re: [PATCH] 8165751: NPE in Signature with java.security.debug=provider

Hi Adam The only behavior change is with the debug output, right? Is this a new pattern that internal optional fields should be defined as an Optional? And, when there is no provider the string form "from: " looks strange, I would rather make it "from nowhere". I would also move the space

RFR 8075618: Create tests to check jarsigner work with multi-version jar

Hi All, Please help to review following changeset, which tests that jarsigner tool works with multi-release JAR files. Webrev: http://cr.openjdk.java.net/~amjiang/8075618/webrev.01/ Bug: https://bugs.openjdk.java.net/browse/JDK-8075618 Thanks, Amanda

On 8171135: Include javadoc on JarSigner API in security doc

Hi All I've create a new bug to include the javadoc of the non-Java SE JarSigner API into security doc: https://bugs.openjdk.java.net/browse/JDK-8171135 If you think this is OK, I'll move the bug to doc. Thanks Max

Re: RFR 8168979: @implNote for invalid FilePermission

Hi Max, Don't count me as reviewer - but I see a mismatched comment in the file: 209 /** 210 * Creates FilePermission objects with special internals. 211 * See {@link FilePermCompat#newPermPlusAltPath(Permission)} and 212 * {@link

Re: RFR[9] JDK-8171043: ServerIdentityTest.java fails on Windows

Hi Xuelei, Thanks for your comments. Please review this new webrev: http://cr.openjdk.java.net/~jjiang/8171043/webrev.01/ Best regards, John Jiang On 2016/12/12 13:07, Xuelei Fan wrote: Hi John, It's a good catch of the problem. Looks like the server side should read the HTTP request at

Re: RFR 8168979: @implNote for invalid FilePermission

> On Dec 12, 2016, at 6:03 PM, Daniel Fuchs wrote: > > Hi Max, > > Don't count me as reviewer - but I see a mismatched comment > in the file: > > 209 /** > 210 * Creates FilePermission objects with special internals. > 211 * See {@link

Re: RFR[9] JDK-8171043: ServerIdentityTest.java fails on Windows

Looks fine to me. Thanks, Xuelei On 12/12/2016 2:29 AM, John Jiang wrote: Hi Xuelei, Thanks for your comments. Please review this new webrev: http://cr.openjdk.java.net/~jjiang/8171043/webrev.01/ Best regards, John Jiang On 2016/12/12 13:07, Xuelei Fan wrote: Hi John, It's a good catch of

Re: [PATCH] 8165751: NPE in Signature with java.security.debug=provider

Okay. I changed getProvider() to return this.provider.orElse(null), which will allow this method to return null. For consistency, I allow all other providers (in Instance and Service) to be null using Optional.ofNullable(). Hopefully, I found and fixed all the whitespace issues, too. Here is