Re: Code Review Request, JDK-8171337 Check for correct SSLEngineImpl/SSLSocketImpl.setSSLParameters handshaker update method

2016-12-19 Thread Bradford Wetmore
For SSLSocket, there are other .started() methods with similar conditions, should those be changed as well? Thanks, Brad On 12/16/2016 11:03 AM, Xuelei Fan wrote: Hi Brad, Please review this handshake update method miss-use fix: http://cr.openjdk.java.net/~xuelei/8171337/webrev.00/ The

Re: Code Review Request JDK-8129988 JSSE should create a single instance of the cacerts KeyStore

2016-12-19 Thread Sean Mullan
Here are more comments on TrustStoreManager: 87-93: these variables can be declared private 120 new PrivilegedAction() { use <> operator 152 // Not break, so the file is accessbile. s/accessbile/inaccessible/ 156

Re: Code Review Request, JDK-8171337 Check for correct SSLEngineImpl/SSLSocketImpl.setSSLParameters handshaker update method

2016-12-19 Thread Xuelei Fan
On 12/19/2016 12:20 PM, Bradford Wetmore wrote: For SSLSocket, there are other .started() methods with similar conditions, should those be changed as well? The one in SSLSocketImpl is used to get the handshake application protocol (getHandshakeApplicationProtocol, line 2661-2664), better to us

Re: RFR 8170900: Issue with FilePermission::implies for wildcard flag(-)

2016-12-19 Thread Wang Weijun
Ping again. > On Dec 14, 2016, at 1:53 PM, Wang Weijun wrote: > > An clarification is added to FilePermission::implies: > > * @implNote > > * a simple {@code npath} is recursively inside a wildcard {@code npath} > * if and only if {@code simple_npath.relativize(wildca