265 if (descriptor.equals(temporaryDesc) && (ks != null)) {
Not sure if JVM will optimize this, but probably better to check if ks != null
first, and avoid calling equals unless necessary:
265 if (ks != null && descriptor.equals(temporaryDesc)) {
Also, similar comment
Thanks for the comments.
http://cr.openjdk.java.net/~xuelei/8129988/webrev.05/
I re-write the getTrustedCerts() implementation. It looks more compact now.
Thanks,
Xuelei
On 1/5/2017 8:13 AM, Sean Mullan wrote:
265 if (descriptor.equals(temporaryDesc) && (ks != null)) {
Not s
if ((certs != null) && descriptor.equals(temporaryDesc)) {
return certs;
} else if (certs != null) { // use new descriptor
This would be more readable as:
if (certs != null) {
if (descriptor.equals(temporaryDesc)) {
Hi,
Please review an implementation mistakes while converting SSLv2Hello
message to SSL/TLS ClientHello message.
http://cr.openjdk.java.net/~xuelei/8172273/webrev.00/
Thanks,
Xuelei
Looks good.
Thanks,
Brad
On 1/5/2017 3:10 PM, Xuelei Fan wrote:
Hi,
Please review an implementation mistakes while converting SSLv2Hello
message to SSL/TLS ClientHello message.
http://cr.openjdk.java.net/~xuelei/8172273/webrev.00/
Thanks,
Xuelei
