Re: RFR JDK-8179614: Test for jarsigner on verifying jars that are signed and timestamped by other JDK releases

2017-06-12 Thread sha . jiang
Hi Max, Would you like to review the updated webrev: http://cr.openjdk.java.net/~jjiang/8179614/webrev.02/ It can create certificate without -sigalg and -keysize, and jar signing also can use this certificate. Best regards, John Jiang On 09/06/2017 22:04, Weijun Wang wrote: On 06/09/2017 09

Re: RFR JDK-8179614: Test for jarsigner on verifying jars that are signed and timestamped by other JDK releases

2017-06-12 Thread Weijun Wang
Great. Only 2 questions: 459 // Return key sizes according to the specified key algorithm. 460 private static int[] keySizes(String digestAlgorithm, String keyAlgorithm) { 461 if (digestAlgorithm == DEFAULT) { 462 return new int[] { 0 }; 463 } 464 465

Re: Stricter Public Key checking corrupts JKS

2017-06-12 Thread Sean Mullan
Hi Bernd, This issue should be fixed in 8u131. Can you try that and let us know? --Sean On 6/9/17 10:18 PM, Bernd wrote: I noticed there is a bug (8177657,etc) about stricter DER checking on JDK Certificate code. I have an JKS Keystore which no longer can be opened because of that. I unders

Re: RFR 8181841: A TSA server returns timestamp with precision higher than milliseconds

2017-06-12 Thread Vincent Ryan
This approach looks fine to me given the limitation on the precision of Date. Just one issue: why remove the upper bound at l.277 in DerInputBuffer.java Thanks. > On 12 Jun 2017, at 05:22, Weijun Wang wrote: > > Please review this fix at > > http://cr.openjdk.java.net/~weijun/8181841/webrev

Re: RFR 8181841: A TSA server returns timestamp with precision higher than milliseconds

2017-06-12 Thread Weijun Wang
On 06/12/2017 08:47 PM, Vincent Ryan wrote: This approach looks fine to me given the limitation on the precision of Date. Just one issue: why remove the upper bound at l.277 in DerInputBuffer.java Before this fix, the maximum length of a GeneralizedTime is 2017010123.123+0800 0

Re: RFR 8181841: A TSA server returns timestamp with precision higher than milliseconds

2017-06-12 Thread Michael StJohns
On 6/12/2017 9:18 AM, Weijun Wang wrote: On 06/12/2017 08:47 PM, Vincent Ryan wrote: This approach looks fine to me given the limitation on the precision of Date. Just one issue: why remove the upper bound at l.277 in DerInputBuffer.java Before this fix, the maximum length of a GeneralizedT

Re: RFR JDK-8179614: Test for jarsigner on verifying jars that are signed and timestamped by other JDK releases

2017-06-12 Thread sha . jiang
Hi Max, On 12/06/2017 17:29, Weijun Wang wrote: Great. Only 2 questions: 459 // Return key sizes according to the specified key algorithm. 460 private static int[] keySizes(String digestAlgorithm, String keyAlgorithm) { 461 if (digestAlgorithm == DEFAULT) { 462

RFR[10] JDK-8179564: Missing @bug for tests added with JDK-8165367

2017-06-12 Thread sha . jiang
Hi, Please review the below patch for adding @bug tag for test sun/security/ssl/CertPathRestrictions/TLSRestrictions.java. diff -r 3801153e1036 test/sun/security/ssl/CertPathRestrictions/TLSRestrictions.java --- a/test/sun/security/ssl/CertPathRestrictions/TLSRestrictions.java Mon Jun 12 12:4

Re: RFR[10] JDK-8179564: Missing @bug for tests added with JDK-8165367

2017-06-12 Thread Weijun Wang
This looks good. Thanks Max On 06/13/2017 09:28 AM, sha.ji...@oracle.com wrote: Hi, Please review the below patch for adding @bug tag for test sun/security/ssl/CertPathRestrictions/TLSRestrictions.java. diff -r 3801153e1036 test/sun/security/ssl/CertPathRestrictions/TLSRestrictions.java ---

Re: RFR 8181841: A TSA server returns timestamp with precision higher than milliseconds

2017-06-12 Thread Weijun Wang
Hi Michael I cannot access ISO 8601 but according to https://en.wikipedia.org/wiki/GeneralizedTime: A GeneralizedTime is a time format in the ASN.1 notation. It consists of a string value representing the calendar date, as defined in ISO 8601, a time of day with an optional fractional seconds e

Re: RFR 8181841: A TSA server returns timestamp with precision higher than milliseconds

2017-06-12 Thread Weijun Wang
On 06/13/2017 09:44 AM, Weijun Wang wrote: Hi Michael I cannot access ISO 8601 but according to https://en.wikipedia.org/wiki/GeneralizedTime: A GeneralizedTime is a time format in the ASN.1 notation. It consists of a string value representing the calendar date, as defined in ISO 8601, a tim