[9] RFR 8181978: Keystore probing mechanism fails for large PKCS12 keystores

2017-06-13 Thread Vincent Ryan
Martin has reported a serious regression involving PKCS12 keystores in JDK 9. It affects large PKCS12 keystores loaded using the new KeyStore.getInstance(File, xxx) method. The error is due to a typo in the masks used by the keystore type detection mechanism. Bug: https://bugs.openjdk.java.net/b

Re: [9] RFR 8181978: Keystore probing mechanism fails for large PKCS12 keystores

2017-06-13 Thread Sean Mullan
Looks fine to me. --Sean On 6/13/17 7:31 AM, Vincent Ryan wrote: Martin has reported a serious regression involving PKCS12 keystores in JDK 9. It affects large PKCS12 keystores loaded using the new KeyStore.getInstance(File, xxx) method. The error is due to a typo in the masks used by the keys

Stricter Public Key checking corrupts JKS

2017-06-13 Thread Bernd Eckenfels
The keystore I have here (which has leading 0 in Modulus in 1 cert and 0 in serial number in another) does not open in test program or keytool.exe with 8u131 (sorry last mail 7u131 was a typo) This happens before the password query: C:\Users> "c:\Program Files\Java\jdk1.8.0_131\bin\keytool.exe"

Re: RFR JDK-8179614: Test for jarsigner on verifying jars that are signed and timestamped by other JDK releases

2017-06-13 Thread sha . jiang
Sean and Max, Please review this updated webrev: http://cr.openjdk.java.net/~jjiang/8179614/webrev.03/ The main changes are: 1. It provides two new properties, tsaList and tsaListFile, for specifying a list of TSA services. And a new report column [TSA] is introduced. This column just display

Re: Code review request: JDK-8046295 - Support Trusted CA Indication extension

2017-06-13 Thread Martin Balao
Hi Xuelei, The new webrev.01 is ready: * http://people.redhat.com/mbalaoal/webrevs/jdk_8046295_trusted_ca/2017_06_13/8046295.webrev.01/ (browse online) * http://people.redhat.com/mbalaoal/webrevs/jdk_8046295_trusted_ca/2017_06_13/8046295.webrev.01.zip (zip, download) The following changes have

Re: RFR 8181841: A TSA server returns timestamp with precision higher than milliseconds

2017-06-13 Thread Michael StJohns
Hi Max - I think I pushed the wrong button and sent out the wrong email. My original email had this (limit is 6 digits) comment in it, but I'd actually decided not to send it because I couldn't find a definitive source. X.680 used the phrase "a time of day, to any of the precisions defined