Re: RFR : 8159035: com/sun/crypto/provider/Cipher/CTS/CTSMode.java test crashed due to unhandled case of cipher length value as 0

2017-08-25 Thread Seán Coffey
Tony pointed out off-list that the change to encodeISOArray() might not work. "I'm not certain the change to encodeISOArray() is not going to work. In 8, that method can be replaced by an intrinsic and miss your additional check. Unlike in 9 where implEncodeISOArray() is intrinsfied. It mayb

Re: RFR : 8159035: com/sun/crypto/provider/Cipher/CTS/CTSMode.java test crashed due to unhandled case of cipher length value as 0

2017-08-25 Thread Anthony Scarpino
Looks good Tony > On Aug 25, 2017, at 6:28 AM, Seán Coffey wrote: > > Tony pointed out off-list that the change to encodeISOArray() might not work. > > "I'm not certain the change to encodeISOArray() is not going to work. In 8, > that method can be replaced by an intrinsic and miss your addit

Code Review Request, JDK-8179654 New JDK 9 typos in SSLEngineResult

2017-08-25 Thread Xuelei Fan
Hi, Please review this spec typo update in SSLEngineResult: http://cr.openjdk.java.net/~xuelei/8179654/webrev.00/ Thanks, Xuelei

Re: Code Review Request, JDK-8179654 New JDK 9 typos in SSLEngineResult

2017-08-25 Thread Oracle
Looks fine Tony > On Aug 25, 2017, at 5:53 PM, Xuelei Fan wrote: > > Hi, > > Please review this spec typo update in SSLEngineResult: > > http://cr.openjdk.java.net/~xuelei/8179654/webrev.00/ > > Thanks, > Xuelei

Re: Code Review Request, JDK-8179654 New JDK 9 typos in SSLEngineResult

2017-08-25 Thread Bradford Wetmore
+1 Brad On 8/25/2017 6:24 PM, Oracle wrote: Looks fine Tony On Aug 25, 2017, at 5:53 PM, Xuelei Fan wrote: Hi, Please review this spec typo update in SSLEngineResult: http://cr.openjdk.java.net/~xuelei/8179654/webrev.00/ Thanks, Xuelei