Re: RFR[11] JDK-8146293 "Add Support for RSA-PSS Signature Algorithm as in PKCS#1 v2.2"

2018-05-14 Thread Valerie Peng
Hi Brad, The latest webrev is at http://cr.openjdk.java.net/~valeriep/8146293/webrev.04/ The only difference between webrev.03 and webrev.04 is the review comments from the CSR. Thanks, Valerie On 3/27/2018 6:40 PM, Valerie Peng wrote: Hi Brad, Can you please help review the changes for RSA

[RFR]: JDK-8203182 - Release session if initialization of SunPKCS11 Signature fails

2018-05-14 Thread Martin Balao
Hi, Can I have a review for "JDK-8203182 - Release session if initialization of SunPKCS11 Signature fails" [1]? * http://cr.openjdk.java.net/~mbalao/webrevs/8203182/8203182.webrev.00/ * http://cr.openjdk.java.net/~mbalao/webrevs/8203182/8203182.webrev.00.zip Thanks in advanced! Martin.- -- [

Re: RFR 8201867: Kerberos keytabs with holes in certain places are parsed incorrectly

2018-05-14 Thread Valerie Peng
I will take a look in a day or two if no one else get to it. Valerie On 4/24/2018 7:42 AM, Weijun Wang wrote: Please take a review at http://cr.openjdk.java.net/~weijun/8201867/webrev.00/ When the hole in keytab is right on the 8192 buffer boundary, skip(n) does not return n. I are not

Re: RFR (+CSR) 8201627: Kerberos sequence number issues

2018-05-14 Thread Valerie Peng
Hi Max, I think it'd be clearer to mention default behavior first and then mention the system property for overriding it if necessary. Something like following: When mutual auth is not requested by the Kerberos 5 initiator, there is no way to negotiate acceptor's initial sequence number. Wit

Re: RFR (+CSR) 8201627: Kerberos sequence number issues

2018-05-14 Thread Weijun Wang
> On May 15, 2018, at 8:32 AM, Valerie Peng wrote: > > Hi Max, > > I think it'd be clearer to mention default behavior first and then mention > the system property for overriding it if necessary. Something like following: > > When mutual auth is not requested by the Kerberos 5 initiator, the