Re: RFR: ChaCha20 and ChaCha20/Poly1305 Cipher implementations

Looks fine to me. --Sean On 5/30/18 5:39 PM, Jamil Nimeh wrote: Hopefully the final set of updates before committing this feature: * Updated the ChaChaEngine implementations in ChaCha20Cipher.java to properly conform to Cipher's specification when the output buffer used in doUpdate i

[8u-dev] Request for Review and Approval to Backport 8189760 : sun/security/ssl/CertPathRestrictions/TLSRestrictions.java failed with unexpected Exception intermittently

Hello! The test failure (in the subj. line) was observed in JDK 8u, so I'd like to backport the fix. The patch did not apply cleanly due to the difference in couple of lines, thus the re-review request. (Specifically, the difference is in TLSRestrictions.java, lines 216 and 221 of patched

Re: RFR: 8191031: Remove several Symantec Root CAs

Looks good. --Sean On 5/30/18 3:05 PM, Rajan Halade wrote: May I request you to review this fix to remove listed Symantec root certificates. Webrev: http://cr.openjdk.java.net/~rhalade/8191031/webrev.00/ Thanks, Rajan

Re: [8u-dev] Request for Review and Approval to Backport 8189760 : sun/security/ssl/CertPathRestrictions/TLSRestrictions.java failed with unexpected Exception intermittently

Looks fine Ivan. Approved for jdk8u-dev. regards, Sean. On 31/05/2018 18:20, Ivan Gerasimov wrote: Hello! The test failure (in the subj. line) was observed in JDK 8u, so I'd like to backport the fix. The patch did not apply cleanly due to the difference in couple of lines, thus the re-re

Re: [8u-dev] Request for Review and Approval to Backport 8189760 : sun/security/ssl/CertPathRestrictions/TLSRestrictions.java failed with unexpected Exception intermittently

Thanks Seán! On 5/31/18 12:13 PM, Seán Coffey wrote: Looks fine Ivan. Approved for jdk8u-dev. regards, Sean.

Re: Code Review Request: TLS 1.3 Implementation

> Here is the webrev: > http://cr.openjdk.java.net/~xuelei/8196584/webrev-full.00 Update: http://hg.openjdk.java.net/jdk/sandbox/rev/e57205a6e4ee The above update took care of integer overflow, and removed a few unused code and comments. Thanks, Xuelei On 5/25/2018 4:45 PM, Xuelei F

Re: [RFR]: JDK-8203182 - Release session if initialization of SunPKCS11 Signature fails

Hi Martin, Thanks for covering additional scenarios. The updated webrev looks good to me. I will sponsor your patch. Thanks, Valerie On 5/24/2018 12:13 PM, Martin Balao wrote: Hi Valerie, Thanks for your review. These are the cases I identified:  * engineSign and engineVerify include a try

RFR: 8196141: Add GoDaddy root certificates

Please review this fix to add GoDaddy root certificates to cacerts. Webrev: http://cr.openjdk.java.net/~rhalade/8196141/webrev.00/ Thanks, Rajan

Re: Code Review Request: TLS 1.3 Implementation

> http://cr.openjdk.java.net/~xuelei/8196584/webrev-full.00 AlpnExtension.java -- Looks fine to me. CertificateRequest.java --- Looks fine to me. CertificateStatus.java -- - 42 * Pack of the CertificateStatus handshake message. + 42 *