Re: Code Review Request: TLS 1.3 full handshake (JDK-8196584)

All good catches! Thanks, Xuelei On 6/13/2018 9:46 PM, Anthony Scarpino wrote: DTLSRecord.java & SSLRecord.java The two variables below not used.  They weren't used before the code restructuring either.   maxDataSizeMinusOneByteRecord   maxAlertRecordSize Tony On 06/13/2018 02:21 PM, Ant

Re: RFR 8177334: Update xmldsig implementation to Apache Santuario 2.1.1

Here are some comments so far. I should be able to finish reviewing this by tomorrow. - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/utils/EncryptionConstants.java - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/utils/EncryptionElement

Re: RFR 8177334: Update xmldsig implementation to Apache Santuario 2.1.1

> On Jun 15, 2018, at 2:19 AM, Sean Mullan wrote: > > Here are some comments so far. I should be able to finish reviewing this by > tomorrow. > > - > src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/utils/EncryptionConstants.java The MessageDigest algorithms are r