Looks fine to me.
Thanks,
Xuelei
On 6/29/2018 11:30 AM, Valerie Peng wrote:
Xuelei,
Can you please help reviewing this fix for JCK test failures?
Essentially, the JCK tests use key created with null algorithm,
encoding, and format for triggering InvalidKeyException. However, the
SunRsaSign
Xuelei,
Can you please help reviewing this fix for JCK test failures?
Essentially, the JCK tests use key created with null algorithm,
encoding, and format for triggering InvalidKeyException. However, the
SunRsaSign provider code throw NPE so test failures are observed. Null
checks are added
Hi Xuelei,
Thanks for your notification.
This is on my backlog again but don't have an ETA yet.
Kind regards,
Martin.-
On Thu, Jun 28, 2018 at 1:14 PM, Xuelei Fan wrote:
> Hi Martin,
>
> The TLS 1.3 implementation was integrated into the mainline.
>
> I know you have multiple contributions
Could you please review the changes
Webrev: http://cr.openjdk.java.net/~pkoppula/8074462/webrev.00/
JBS: https://bugs.openjdk.java.net/browse/JDK-8074462
To fix handshake message out-of-order issues, we extracted required classes/
code from JEP 219 implementation.
Contributed by:
On 29/06/2018 09:22, Sibabrata Sahoo wrote:
May I get the approval from serviceability-...@openjdk.java.net.
This a test only change to update the keystores and the list of
ciphers/protocols that the test uses. There's nothing serviceability
specific here so having a Reviewer from the
May I get the approval from serviceability-...@openjdk.java.net.
Thanks,
Siba
-Original Message-
From: Xuelei Fan
Sent: Thursday, June 28, 2018 9:27 PM
To: Daniel Fuchs ; Sibabrata Sahoo
; jmx-...@openjdk.java.net;
security-dev@openjdk.java.net; serviceability-...@openjdk.java.net
I've introduced a new test helper class in the jdk/test/lib/jfr
directory to help with the dual test nature of the new tests. It's
helped alot with test code duplication.
Looked at use of @DataAmount(DataAmount.BITS) also. Not sure if it's
fits. The output is displayed in units like "KiB" -
Hi Prasad,
Thanks for take care of this issue.
SSLEngineImpl.java
--
1422 private HandshakeStatus finishHandshake() {
1423 handshaker = null;
1424 connectionState = cs_DATA;
1425 return HandshakeStatus.FINISHED;
1426}
This method are used in two
