Failing PKCS11 tests if NSS is not installed

2018-07-03 Thread Thomas Stüfe
Hi all, I just opened https://bugs.openjdk.java.net/browse/JDK-8206258 - the tests fail if NSS is not properly installed, which is the case on some of our test machines. I am not an expert here. The test code reads as if in this case the tests should just be skipped; however, this is not what hap

RE: [8u] RFR: 8074462: Handshake messages can be strictly ordered

2018-07-03 Thread Prasadrao Koppula
Hi Xuelei, Thanks for quick review. All the points are valid and implemented with your suggestions. Thanks, Prasad.K -Original Message- From: Xuelei Fan Sent: Friday, June 29, 2018 8:17 PM To: Prasadrao Koppula ; security-dev@openjdk.java.net Subject: Re: [8u] RFR: 8074462: Handshake

RFR[12] JDK-8179098 "Crypto AES/ECB encryption/decryption performance regression (introduced in jdk9b73)"

2018-07-03 Thread Valerie Peng
Hi Tony, Would you have time to review this? Instead of doing the bounds check per block, the changes move the bounds check up one level. Bug: https://bugs.openjdk.java.net/browse/JDK-8179098 Webrev: http://cr.openjdk.java.net/~valeriep/8179098/webrev.00/ Thanks, Valerie

RFR[11] JDK-8206258: [Test Error] sun/security/pkcs11 tests fail if NSS libs not found

2018-07-03 Thread sha . jiang
Hi, If NSS libs are unavailable, PKCS11 tests fail when checking NSS version. This patch tries to fix this issue. JBS: https://bugs.openjdk.java.net/browse/JDK-8206258 Webrev: http://cr.openjdk.java.net/~jjiang/8206258/webrev.00/ Best regards, John Jiang

Re: RFR[11] JDK-8206258: [Test Error] sun/security/pkcs11 tests fail if NSS libs not found

2018-07-03 Thread Thomas Stüfe
Hi, Unfortunately this is not enough. Running tests with your patch and NSS libs disabled (I renamed libsoftokn3.so) yields the following errors: sun/security/pkcs11/Secmod/AddPrivateKey.java Failed. Execution failed: `main' threw exception: java.