Re: RFR[jdk8u-dev]: 8134124: sun/security/tools/jarsigner/warnings.sh fails when using Hindi locale

2018-07-08 Thread Weijun Wang
Changes looks fine. One day we can modify it to a Java program using SecurityTools::jarsigner. Thanks Max > On Jul 6, 2018, at 5:34 PM, Ramanand Patil wrote: > > Hi all, > Please review this trivial test fix: > Bug: https://bugs.openjdk.java.net/browse/JDK-8134124 > Webrev: http://cr.openjdk.j

[11] RFR 8198352: java.util.MissingResourceException: sun.security.util.AuthResources when trying to use com.sun.security.auth.module.UnixLoginModule

2018-07-08 Thread Weijun Wang
Please take a review at http://cr.openjdk.java.net/~weijun/8198352/webrev.00/ You should not use resources in hashCode(). Thanks Max

Re: [11] RFR 8198352: java.util.MissingResourceException: sun.security.util.AuthResources when trying to use com.sun.security.auth.module.UnixLoginModule

2018-07-08 Thread Xuelei Fan
Looks fine to me. Xuelei On 7/8/2018 8:02 PM, Weijun Wang wrote: Please take a review at http://cr.openjdk.java.net/~weijun/8198352/webrev.00/ You should not use resources in hashCode(). Thanks Max

[8u] RFR for backport of JDK-8175120 and JDK-8164656

2018-07-08 Thread Ramkumar Sunderbabu
Please review the backports of JDK-8175120 and JDK-8164656. Overview - Removing old tests on KDC timeout policy and replacing it with new one. Original mail threads JDK-8164656 - http://mail.openjdk.java.net/pipermail/security-dev/2016-August/014696.html JDK-8175120 - http://mail.openjdk.