Re: RFR[11] JDK-8206171: Signature#getParameters for RSASSA-PSS throws ProviderException when not initialized

2018-07-19 Thread Sean Mullan
Hi Valerie, Max - I took a fresh look at this issue this morning. I think we are getting bogged down by trying to adjust within the current wording, which is somewhat awkward and hard to understand. So, I think it might be better to break up the wording into multiple sentences. Here's a cut at

Re: EC weirdness

2018-07-19 Thread Michael StJohns
On 7/16/2018 4:42 PM, Adam Petcher wrote: I think the reason for the hard-coded curves is largely historical, and I don't know of a security-related reason for it (other than the prevention of insecure parameters). Though it has the additional benefit that it simplifies the interface a lot, bec

Re: RFR[11] JDK-8206171: Signature#getParameters for RSASSA-PSS throws ProviderException when not initialized

2018-07-19 Thread Valerie Peng
Hi Sean, Thanks for the suggestion, I like it. Max, any objection or concern before I update the webrev and CSR? Valerie On 7/19/2018 7:28 AM, Sean Mullan wrote: Hi Valerie, Max - I took a fresh look at this issue this morning. I think we are getting bogged down by trying to adjust within

Re: RFR[11] JDK-8206171: Signature#getParameters for RSASSA-PSS throws ProviderException when not initialized

2018-07-19 Thread Wang Weijun
> 在 2018年7月20日,05:18,Valerie Peng 写道: > > Hi Sean, > > Thanks for the suggestion, I like it. Me too. > > Max, any objection or concern before I update the webrev and CSR? No. Thanks Max > > Valerie > > >> On 7/19/2018 7:28 AM, Sean Mullan wrote: >> Hi Valerie, Max - >> >> I took a

RFR(s): 8204196: integer cleanup

2018-07-19 Thread Anthony Scarpino
I need a review of some integer check cleanups. http://cr.openjdk.java.net/~ascarpino/int/webrev/ thanks Tony

Re: RFR(s): 8204196: integer cleanup

2018-07-19 Thread Xuelei Fan
Looks fine to me. Thanks, Xuelei On 7/19/2018 5:02 PM, Anthony Scarpino wrote: I need a review of some integer check cleanups. http://cr.openjdk.java.net/~ascarpino/int/webrev/ thanks Tony

Re: RFR[11] JDK-8206171: Signature#getParameters for RSASSA-PSS throws ProviderException when not initialized

2018-07-19 Thread Valerie Peng
Thanks Max and Sean for the review and suggestions. I have updated the webrev accordingly and finalized CSR. Webrev: http://cr.openjdk.java.net/~valeriep/8206171/webrev.04/ CSR: https://bugs.openjdk.java.net/browse/JDK-8206864 Valerie On 7/19/2018 3:13 PM, Wang Weijun wrote: 在 2018年7月20日,05

Bug in HttpClient

2018-07-19 Thread Thomas Lußnig
*Hi,* *i found an bug in JDK 10 with the new HttpClient. It does not handle responses wihtout contentlength correctly. Normally i would expect that the content is returned even without content length. Since i can not open an JDK bug i hope some person from the list can do it. Below is an exampl