[11] RFR: 8208496: New Test to verify concurrent behavior for TLS.

Hi Xuelei, Please review the patch for, JBS: https://bugs.openjdk.java.net/browse/JDK-8208496 Webrev: http://cr.openjdk.java.net/~ssahoo/8208496/webrev.00/ This is a new Test which test concurrent behavior of TLS. It uses 50 client thread to access a single server port concurrently an

Re: RFR: 8208583: Better management of internal KeyStore buffers

No - no problem at all. Some extra exception handling but probably best for the long run. http://cr.openjdk.java.net/~coffeys/webrev.8208583.v3/webrev/index.html regards, Sean. On 02/08/2018 02:13, Weijun Wang wrote: 1. I wasn't able to rename to destroy since that method is reserved for th

Re: RFR: 8207775: Better management of CipherCore buffers

Thanks Tony. I was asked off thread to add some comments to help code maintenance also. webrev updated. Hope we're nearly ready to push now. http://cr.openjdk.java.net/~coffeys/webrev.8207775.v4/webrev/ regards, Sean. On 01/08/2018 18:41, Anthony Scarpino wrote: That looks fine to me. Tony

Re: RFR 8201290: keytool importcert fails with CertificateParsingException if unknown certificate algorithms should be imported

You will need to file a CSR since you are extending the options to -printcert to now include the provider name, class, etc. Also, there is no test. --Sean On 8/1/18 10:28 PM, Weijun Wang wrote: Please take a review at http://cr.openjdk.java.net/~weijun/8201290/webrev.00/ Please note I di

Re: RFR 8201290: keytool importcert fails with CertificateParsingException if unknown certificate algorithms should be imported

https://bugs.openjdk.java.net/browse/JDK-8208689 filed. --Max > On Aug 2, 2018, at 11:05 PM, Sean Mullan wrote: > > You will need to file a CSR since you are extending the options to -printcert > to now include the provider name, class, etc.

Re: RFR: 8208583: Better management of internal KeyStore buffers

KeyProtector.java: 113 pbeKeySpec.clearPassword(); You can also put this into the finally block. 189 Arrays.fill(plain, (byte) 0x00); Can this be in finally? JavaKeyStore.java: 149 Arrays.fill(passwordBytes, (byte) 0x00); In other cases, you call it in a fin

Re: RFR: 8208583: Better management of internal KeyStore buffers

All valid comments Max. Changes made. Webrev at http://cr.openjdk.java.net/~coffeys/webrev.8208583.v4/webrev/index.html I wonder why DestroyedFailedException was a checked exception, what can we do if it's thrown? I guess we could log a message, but given the limited usage case here, I don't

RFR 8207783: PoodleSSLv3 test update for TLSv1.2 and TLSv1.3

Hi All, Please help to review the changeset below, which update PoodleSSLv3 test for newer protocol versions http://sqeweb.us.oracle.com/net/scanas415/export/corelibs/users/amjiang/webrev/8207783/webrev.00/ Thanks, Amanda

Re: [11] RFR: 8208496: New Test to verify concurrent behavior for TLS.

Hi Siba, Would it be better to check how many connections the server accepts? In your case, the server must accept 50 (no more no less) connections; otherwise, some problem may raise. And I suppose, when the server thread is interrupted, the server socket may not be closed. The server should e

Re: RFR: 8207775: Better management of CipherCore buffers

Looks good. Only comment is update the copyright year. No need to regenerate a webrev. Assuming it passes all the tests I say it’s ready to push. Tony > On Aug 2, 2018, at 5:15 AM, Seán Coffey wrote: > > Thanks Tony. I was asked off thread to add some comments to help code > maintenance also