On 27/08/2018 12:25, Weijun Wang wrote:
Would it be possible (in the future) for 2 modules to use the same name for a
private package? If yes, we can dup the sun.security.action classes into
java.security.jgss without having to modify all calls.
Not if both modules are mapped to the same class
Hi,
Please review this release note:
https://bugs.openjdk.java.net/browse/JDK-8210070
Per the "supported_groups" extension specification, the supported_groups
extension should not present in the ServerHello handshake message. JDK
11 cannot work with TLS servers that wrap the extension in Se
I received some suggestions for improvements to the X25519/X448 code
after the completion of the code review back in March. The improvements
are some additional comments on methods and some rearranged expressions
to prevent integer overflow. The change is very small, please review if
you have 1
As you are already there, would you mind describe the differences
between multByInt() and mult()?
For method description, the comment is normally start with "/**" for
javadoc friendly.
Previously, you have the comment:
// must work when a==r
Do you want to keep it somehow?
Otherwise, look
New webrev: http://cr.openjdk.java.net/~apetcher/8201317/webrev.01/
Let me know if your concerns are addressed. One response is inline below.
On 8/28/2018 1:10 PM, Xuelei Fan wrote:
As you are already there, would you mind describe the differences
between multByInt() and mult()?
For method d
Looks fine to me.
Thanks,
Xuelei
On 8/28/2018 10:50 AM, Adam Petcher wrote:
New webrev: http://cr.openjdk.java.net/~apetcher/8201317/webrev.01/
Let me know if your concerns are addressed. One response is inline below.
On 8/28/2018 1:10 PM, Xuelei Fan wrote:
As you are already there, would yo
I need a review of this fix. Simple change to throw an
UnsupportedOperationException using SSLSocket with DTLS. Additionally
use SSLEngine for some of the generic methods that were defaulting to
SSLSocket This is only for the JSSE provider.
http://cr.openjdk.java.net/~ascarpino/8208641/webr
