Re: Release note review, JDK-8210070, Release Note: The "supported_groups" extension should not present in the ServerHellos handshake message

2018-08-31 Thread Alan Bateman
On 28/08/2018 15:17, Xuelei Fan wrote: Hi, Please review this release note:    https://bugs.openjdk.java.net/browse/JDK-8210070 Per the "supported_groups" extension specification, the supported_groups extension should not present in the ServerHello handshake message. JDK 11 cannot work wit

RE: [RFR] 8205525 : Improve exception messages during manifest parsing of jar archives

2018-08-31 Thread Baesken, Matthias
Hi Max : > > - No need to "import java.security.Security". Sure I can remove this, it is a leftover. > - In the updated read() method, I think there is no need to use an "int > offset" > parameter. "int lineNumber" is enough and you can modify it and return it > without a new local variable.

Re: [RFR] 8205525 : Improve exception messages during manifest parsing of jar archives

2018-08-31 Thread Weijun Wang
> On Aug 31, 2018, at 8:52 PM, Baesken, Matthias > wrote: > > Hi Max : > >> >> - No need to "import java.security.Security". > > Sure I can remove this, it is a leftover. > >> - In the updated read() method, I think there is no need to use an "int >> offset" >> parameter. "int lineNumbe

Re: Release note review, JDK-8210070, Release Note: The "supported_groups" extension should not present in the ServerHellos handshake message

2018-08-31 Thread Xuelei Fan
As we don't fix it in JDK 11, it is intended to have a known issue note for JDK 11. Xuelei On 8/31/2018 12:25 AM, Alan Bateman wrote: On 28/08/2018 15:17, Xuelei Fan wrote: Hi, Please review this release note:    https://bugs.openjdk.java.net/browse/JDK-8210070 Per the "supported_groups"

Re: Release note review, JDK-8210070, Release Note: The "supported_groups" extension should not present in the ServerHellos handshake message

2018-08-31 Thread Alan Bateman
On 31/08/2018 15:07, Xuelei Fan wrote: As we don't fix it in JDK 11, it is intended to have a known issue note for JDK 11. Yes, a RN-KnownIssue make sense, I'm just trying to understand there is a note showing up under "Build 9". It may be that whatever generates this preview page is using t

Re: How does securely obtain and verify openjdk repositories as a non-contributor?

2018-08-31 Thread Bradford Wetmore
I would suggest contacting o...@openjdk.java.net, they should be able to answer these kinds of infrastructure questions. Best wishes, Brad On 8/30/2018 6:32 PM, David Black wrote: Hi, I am asking this because I am not able to find information on if openjdk uses signed tags/commits & because t

Re: RFR JDK-8029661: JDK-Support TLS v1.2 algorithm in SunPKCS11 provider

2018-08-31 Thread Valerie Peng
Hi Martin, In TestTLS12.java, you call the initSecmod() inside initialize() and when initSecmod() returns false, you return from initialize() and continue down the main(). Is this intentional? Other tests seems to be skipping execution when initSecmod() return false. Changes in webrev.08 res

Re: RFR 6913047: SunPKCS11 memory leak

2018-08-31 Thread Valerie Peng
Hi Martin, With the new model of "creating the key handle as needed", I think we should not allow the direct access of keyID field outside of P11Key class. This field should be made private and accessed through methods. In addition, existing PKCS11.C_XXX() methods with P11 keyID arguments can