Hi Martin,
With the new model of "creating the key handle as needed", I think we
should not allow the direct access of keyID field outside of P11Key
class. This field should be made private and accessed through methods.
In addition, existing PKCS11.C_XXX() methods with P11 keyID arguments
> On Aug 31, 2018, at 8:52 PM, Baesken, Matthias
> wrote:
>
> Hi Max :
>
>>
>> - No need to "import java.security.Security".
>
> Sure I can remove this, it is a leftover.
>
>> - In the updated read() method, I think there is no need to use an "int
>> offset"
>> parameter. "int
As we don't fix it in JDK 11, it is intended to have a known issue note
for JDK 11.
Xuelei
On 8/31/2018 12:25 AM, Alan Bateman wrote:
On 28/08/2018 15:17, Xuelei Fan wrote:
Hi,
Please review this release note:
https://bugs.openjdk.java.net/browse/JDK-8210070
Per the "supported_groups"
On 28/08/2018 15:17, Xuelei Fan wrote:
Hi,
Please review this release note:
https://bugs.openjdk.java.net/browse/JDK-8210070
Per the "supported_groups" extension specification, the
supported_groups extension should not present in the ServerHello
handshake message. JDK 11 cannot work
Hi Max :
>
> - No need to "import java.security.Security".
Sure I can remove this, it is a leftover.
> - In the updated read() method, I think there is no need to use an "int
> offset"
> parameter. "int lineNumber" is enough and you can modify it and return it
> without a new local variable.
