Re: RFR 8210786 : Typo s/overriden/overridden/ in several places

2018-09-15 Thread Weijun Wang
In the bug description you listed some in jdk/internal/org/objectweb/asm, but they are not included in the fix. Is it because those are not doc only but inside source code? There are similar typos in other modules as well. Any reason not to include them. Thanks Max > On Sep 15, 2018, at 2:03 P

Re: [12] Review Request: 8210692 The "com.sun.awt.SecurityWarning" class can be dropped

2018-09-15 Thread Philip Race
Were people mis-reading this as java.desktop ? Yes, its fine, this was added under https://bugs.openjdk.java.net/browse/JDK-8055206 and we should have removed that when jdk.desktop was backed out under https://bugs.openjdk.java.net/browse/JDK-8173409 -phil. On 9/14/18, 11:41 AM, Sean Mullan

Re: [12] Review Request: 8210692 The "com.sun.awt.SecurityWarning" class can be dropped

2018-09-15 Thread Philip Race
It was exported in the past .. and it was publicly documented .. http://www.oracle.com/technetwork/articles/javase/appletwarning-135102.html .. so I think Sergey was correct in his "JDK" scope. Implementation would be for something entirely internal. +1 -phil. On 9/13/18, 7:20 PM, mandy chun

Re: RFR 8210786 : Typo s/overriden/overridden/ in several places

2018-09-15 Thread Ivan Gerasimov
Hi Max! On 9/15/18 6:28 AM, Weijun Wang wrote: In the bug description you listed some in jdk/internal/org/objectweb/asm, but they are not included in the fix. Is it because those are not doc only but inside source code? For the ASM changes, I thought it may be better to fix them in the upstr

Re: RFR 8210786 : Typo s/overriden/overridden/ in several places

2018-09-15 Thread Wang Weijun
This makes sense. No other comment. Thanks Max > 在 2018年9月16日，05:10，Ivan Gerasimov 写道： > > Hi Max! > > >> On 9/15/18 6:28 AM, Weijun Wang wrote: >> In the bug description you listed some in jdk/internal/org/objectweb/asm, >> but they are not included in the fix. Is it because those are not d

Re: RFR (12): 8191053: Provide a mechanism to make system's security manager immutable

2018-09-15 Thread David Black
On 14 September 2018 at 13:46, David Lloyd wrote: > On Thu, Sep 13, 2018 at 3:03 PM Sean Mullan wrote: >> >> This is a SecurityManager related change which warrants some additional >> details for its motivation. >> >> The current System.setSecurityManager() API allows a SecurityManager to >> be s

Re: RFR (12): 8191053: Provide a mechanism to make system's security manager immutable

2018-09-15 Thread David Black
On 14 September 2018 at 15:22, Alan Bateman wrote: > On 14/09/2018 13:46, David Lloyd wrote: >> >> : >>> >>> There are essentially two main parts to this change: >>> >>> 1. Deprecation of System.s[etS]ecurityManager() >> >> We (JBoss) use this method to configure some things at run time (like >> c