Re: RFR 8076190: Customizing the generation of a PKCS12 keystore

2018-09-24 Thread Sean Mullan
On 9/23/18 9:42 AM, Weijun Wang wrote: On Sep 22, 2018, at 2:49 AM, Sean Mullan wrote: Still reviewing but here are some initial comments. It seems this is more than a fix for JDK-8076190. It also adds configuration properties for the PKCS12 algorithms. I think you should expand the scope/de

Re: NPE during SSL handshake caused by HostnameChecker

2018-09-24 Thread Xuelei Fan
Hi Norman, It looks like a bug to me. Would you please file a new bug? Thanks, Xuelei On 9/22/2018 3:40 PM, Norman Maurer wrote: Hi all, I think I found another bug in the the SSL implementation (well really in the TrustManager related part) which leads to a NPE. I was able to reproduce th

Re: NPE during SSL handshake caused by HostnameChecker

2018-09-24 Thread Norman Maurer
Done… Received: We will review your report and have assigned it an internal review ID : 9057381 I used Java8 as Java version but mentioned that it also happens on 11. Hope it helps, Norman > On 24. Sep 2018, at 19:19, Xuelei Fan wrote: > > Hi Norman, > > It looks like a bug to me. Would

Re: RFR (12): 8191053: Provide a mechanism to make system's security manager immutable

2018-09-24 Thread Peter
Hi Alan, Ok will do. I'm guessing the test case needs to be a jtreg test? I haven't used lambda's in a SecurityManager implementation at this time, but will experiment and see what happens. Perhaps an comment in the documentation around implementation and recursion difficulties would be su

Re: RFR 8210395: Add doc to SecurityTools.java

2018-09-24 Thread Weijun Wang
Ping again. > On Sep 5, 2018, at 12:17 PM, Weijun Wang wrote: > > I ran javadoc on test/lib so I can learn the useful helper classes, and find > out SecurityTools.java has no javadoc at all. > > Please review this change > > http://cr.openjdk.java.net/~weijun/8210395/webrev.00/ > > Thanks