JDK-8207775 introduced some performance regressions in the ciphercore
area. Sergey Kuksenko has been looking at this and has contributed the
following patch:
http://cr.openjdk.java.net/~skuksenko/crypto/8209862/
bug report : https://bugs.openjdk.java.net/browse/JDK-8209862
I've been reviewing
Looks like a nice improvement, but is it possible to do this without
duplicating code? For example, code almost identical to this also
appears starting on line 860:
971 } else { // encrypting
972 try {
973 outLen = finalNoPadding(finalBuf, finalOffset, output,
974 outputOffset, finalBufLen);
97
Looks good. After you update the CSR with these changes, I can review it.
--Sean
On 9/28/18 9:36 AM, Weijun Wang wrote:
Webrev updated at
http://cr.openjdk.java.net/~weijun/8076190/webrev.04/
Major changes:
1. Comment out key=value lines in java.security
2. Fix a bug in PBES2Parameters.j
Hello!
A handful of a few similar typos across core-libs/security-libs areas.
BUGURL: https://bugs.openjdk.java.net/browse/JDK-8200381
WEBREV: http://cr.openjdk.java.net/~igerasim/8200381/00/webrev/
Would you please help review the fix?
--
With kind regards,
Ivan Gerasimov
On 10/01/2018 06:11 AM, Seán Coffey wrote:
JDK-8207775 introduced some performance regressions in the ciphercore
area. Sergey Kuksenko has been looking at this and has contributed the
following patch:
http://cr.openjdk.java.net/~skuksenko/crypto/8209862/
bug report : https://bugs.openjdk.java.
The changes look reasonable Ivan
> On Oct 1, 2018, at 7:37 PM, Ivan Gerasimov wrote:
>
> Hello!
>
> A handful of a few similar typos across core-libs/security-libs areas.
>
> BUGURL: https://bugs.openjdk.java.net/browse/JDK-8200381
> WEBREV: http://cr.openjdk.java.net/~igerasim/8200381/00/webr
I checked the last 6 only (SSLEngine+). Looks good.
Brad
On 10/1/2018 4:37 PM, Ivan Gerasimov wrote:
Hello!
A handful of a few similar typos across core-libs/security-libs areas.
BUGURL: https://bugs.openjdk.java.net/browse/JDK-8200381
WEBREV: http://cr.openjdk.java.net/~igerasim/8200381/00
> On Oct 2, 2018, at 2:49 AM, Sean Mullan wrote:
>
> Looks good. After you update the CSR with these changes, I can review it.
Sure.
How do you think of the following change? Shall I also add it?
diff --git a/src/java.base/share/classes/java/security/KeyStore.java
b/src/java.base/share/clas
Changes look fine; thanks,
-Joe
On 10/1/2018 4:43 PM, Lance Andersen wrote:
The changes look reasonable Ivan
On Oct 1, 2018, at 7:37 PM, Ivan Gerasimov wrote:
Hello!
A handful of a few similar typos across core-libs/security-libs areas.
BUGURL: https://bugs.openjdk.java.net/browse/JDK-82
Hi Martin,
For the KeyStore case, they are mostly token objects which the extract
key info approach does not apply?
For your changes in p11_keymgmt.c, I ran into compiler error and SIGBUS
errors on two OS (mac and solaris sparc), I ended up changing variable
initializations as well as memset
Thank you for reviewing!
I just realized that the sentence about SKIP_ARRAY in the javadoc for
SSLSocketImpl.skip() is not relevant, as the temporary array is not
static anymore, so I just removed it.
The updated webrev with this only change, comparing to the previous one,
is here:
http://
11 matches
Mail list logo
