Re: Conceptual feedback on new ECC JEP

2018-10-03 Thread Adam Petcher
I received quite a bit of feedback that questions the value of the new provider, and the "branchless mode" in general. At the same time, nobody has told me that this mode would be useful to them. So I am removing it from the JEP. In short, I will only be doing the second bullet point from my la

Re: RFR 8210395: Add doc to SecurityTools.java

2018-10-03 Thread Sean Mullan
Looks fine to me. --Sean On 9/24/18 11:59 PM, Weijun Wang wrote: Ping again. On Sep 5, 2018, at 12:17 PM, Weijun Wang wrote: I ran javadoc on test/lib so I can learn the useful helper classes, and find out SecurityTools.java has no javadoc at all. Please review this change http://cr.o

Fwd: Re: RFR (12): 8191053: Provide a mechanism to make system's security manager immutable

2018-10-03 Thread Sean Mullan
For those of you that are not also subscribed to security-dev, this is mostly FYI, as the review is winding down, but if you have any comments, let me know. This change will add new token options ("allow" and "disallow") to the java.security.manager system property. The "disallow" option is in

Re: RFR 6913047: SunPKCS11 memory leak

2018-10-03 Thread Valerie Peng
Hi Martin, I found the problem causing the one regression test failure and fixed it. Now Mach5 run is clean. http://cr.openjdk.java.net/~valeriep/6913047Exp/webrev.02 I also made various changes hoping to improve things. You can compare the files in above webrev with yours for differences. G

Re: JGSS Enhancements (contribution by Two Sigma Open Source)

2018-10-03 Thread Nico Williams
On Wed, Oct 03, 2018 at 07:54:15AM +0100, Alan Bateman wrote: > The "How to contribute" [1] is the best place to start. I see you > are listed on the OCA signatories so that gets you through step 0. Indeed. Figuring out how to deal with the OCA is a large reason we took so long to begin this cont

Re: JGSS Enhancements (contribution by Two Sigma Open Source)

2018-10-03 Thread Valerie Peng
Hi Nico, Thanks for submitting the patches, Max is off on Chinese holidays til 7th and I am going to be on vacation til 19th. I suppose no bugs have been filed for these issues? Max and I will take a look upon our return. Regards, Valerie On 10/3/2018 2:30 PM, Nico Williams wrote: On We

Re: JGSS Enhancements (contribution by Two Sigma Open Source)

2018-10-03 Thread Wang Weijun
Yes, I am on vacation now. When I’m back, I’ll post your changes to cr.openjdk.java.net first. Thanks Max > 在 2018年10月4日,06:13,Valerie Peng 写道: > > Hi Nico, > > Thanks for submitting the patches, Max is off on Chinese holidays til 7th and > I am going to be on vacation til 19th. > > I supp

Re: JGSS Enhancements (contribution by Two Sigma Open Source)

2018-10-03 Thread Nico Williams
On Wed, Oct 03, 2018 at 03:13:55PM -0700, Valerie Peng wrote: > Thanks for submitting the patches, Max is off on Chinese holidays > til 7th and I am going to be on vacation til 19th. > > I suppose no bugs have been filed for these issues? Max and I will > take a look upon our return. Great! And

Re: RFR (12): 8191053: Provide a mechanism to make system's security manager immutable

2018-10-03 Thread Stuart Marks
Hi Sean, The new arrangement of using special tokens for java.security.manager makes a lot more sense than having a separate property. Overall, the proposed semantics seem reasonable to me. I have some suggestions to clarify the proposed specification. (But also see below.) From webrev.01:

Re: Fwd: Re: RFR (12): 8191053: Provide a mechanism to make system's security manager immutable

2018-10-03 Thread Sergey Bylokhov
Hi, Sean. One question related to SecurityManager and performance, is it possible to provide a special version of AccessController.doPrivileged which will be noop if SecurityManager is not present? On 03/10/2018 13:12, Sean Mullan wrote: For those of you that are not also subscribed to securit