RFR 8212165: JGSS: Fix cut/paste error in NativeUtil.c

2018-10-14 Thread Weijun Wang
Hi All Please take a review on a change in DEF_JNI_OnLoad of NativeUtil.c: diff --git a/src/java.security.jgss/share/native/libj2gss/NativeUtil.c b/src/java.security.jgss/share/native/libj2gss/NativeUtil.c --- a/src/java.security.jgss/share/native/libj2gss/NativeUtil.c +++ b/src/java.security.jg

Re: RFR[12] JDK-8211978: move testlibrary/jdk/testlibrary/SimpleSSLContext.java and testkeys to network testlibrary

2018-10-14 Thread Weijun Wang
Hi John I see testkeys is directly referenced in AbstractSSLTubeTest.java and FlowTest.java by an inner class also named SimpleSSLContext. Is it very different from the one in SimpleSSLContext.java? Can they be combined? If so, then we have a chance to ASCII-fy the testkeys file and directly in

RFR: 8211426: SSL handshake succeeds under JDK 9 (and earlier) but not under JDK 11

2018-10-14 Thread Anthony Scarpino
I’d like a review of this fix for when DSA is the only key available. It’s debatable how realistic this situation is, but it is a regression and key tool uses dsa by default. The fix is to remove tls1.3 from the default protocols. The placement of the code change is to minimize the keymanager c

Re: RFR 8212165: JGSS: Fix cut/paste error in NativeUtil.c

2018-10-14 Thread Alan Bateman
On 15/10/2018 03:32, Weijun Wang wrote: Hi All Please take a review on a change in DEF_JNI_OnLoad of NativeUtil.c: *diff --git a/src/java.security.jgss/share/native/libj2gss/NativeUtil.c b/src/java.security.jgss/share/native/libj2gss/NativeUtil.c* *--- a/src/java.security.jgss/share/native/l