Re: [PATCH] Typo in SSL log message related to inactive/disabled signature scheme

2018-10-22 Thread Seán Coffey
Looks fine. I'll push this for you. Regards, Sean. On 22/10/18 06:46, Jaikiran Pai wrote: I noticed a typo in one of the SSL log messages, while looking into a log file generated during a SSL handshake. Here's a trivial patch which fixes the typo. I'm not a committer so will need help from some

Re: [PATCH] Typo in SSL log message related to inactive/disabled signature scheme

2018-10-22 Thread Jaikiran Pai
Thank you Sean. -Jaikiran On 22/10/18 3:01 PM, Seán Coffey wrote: > Looks fine. I'll push this for you. > > Regards, > Sean. > > On 22/10/18 06:46, Jaikiran Pai wrote: >> I noticed a typo in one of the SSL log messages, while looking into a >> log file generated during a SSL handshake. Here's a

Re: RFR 8212216: JGSS: Fix leak in exception cases in getJavaOID()

2018-10-22 Thread Sean Mullan
Looks fine to me. It is unusual to have two noreg labels on a bug. Is that acceptable? I would probably choose one or the other. noreg-hard seems more appropriate to me. --Sean On 10/15/18 9:34 PM, Weijun Wang wrote: Please take a review at http://cr.openjdk.java.net/~weijun/8212216/webr

Re: RFR 8212216: JGSS: Fix leak in exception cases in getJavaOID()

2018-10-22 Thread Weijun Wang
Maybe noreg-trivial is for lazy people. I'll remove it and add a comment. Thanks Max > On Oct 22, 2018, at 11:30 PM, Sean Mullan wrote: > > Looks fine to me. It is unusual to have two noreg labels on a bug. Is that > acceptable? I would probably choose one or the other. noreg-hard seems more