Re: RFR 8213009: Refactoring existing SunMSCAPI classes

2018-11-25 Thread Weijun Wang
Hi Valerie Updated webrev at https://cr.openjdk.java.net/~weijun/8213009/webrev.02 Changes: - CSignature.java: * Mentions "RSASSA-PSS" in class spec of CSignature. * CSignature.RSA child classes renamed, For example, Raw -> NONEwithRSA, SHA1 -> SHA1withRSA. References (both class name

Re: RFR: 8213952: Relax DNSName restriction as per RFC 1123

2018-11-25 Thread Weijun Wang
> On Nov 24, 2018, at 12:45 AM, Seán Coffey wrote: > > Thanks for your review Max. I've made the suggested edits. > http://cr.openjdk.java.net/~coffeys/webrev.8213952.v3/webrev/ The change looks fine. Thanks. > > I've also submitted a CSR for this change just to cover the behavioural > asp