On Tue, Nov 20, 2018 at 09:56:36AM +0800, Weijun Wang wrote:
> Please take a review at
>
>https://cr.openjdk.java.net/~weijun/6722928/webrev.01/
>
> We ported [1] the native GSS bridge to Windows in JDK 11, but user still have
> to download and install a native GSS-API library. This code chan
Please review this change to remove TLS v1 and v1.1 from the SE required
algorithms for SSLContext. These TLS protocols have various weaknesses
and are no longer recommended and are being phased out, and thus should
be removed as requirements.
CSR: https://bugs.openjdk.java.net/browse/JDK-8214
Do you know, is there any other way except Cleaner and finalize() to
clean up the allocated resources?
I'm not very sure of the use of static Cleaner:
1. a daemon thread will run underlying.
2. the number of registered actions could be huge in some circumstances.
I'm not very sure if it could b
Looks fine to me. I added myself as Reviewer of the CSR.
Xuelei
On 11/28/2018 11:30 AM, Sean Mullan wrote:
Please review this change to remove TLS v1 and v1.1 from the SE required
algorithms for SSLContext. These TLS protocols have various weaknesses
and are no longer recommended and are bein
Just a nit:
77 throw new IOException("DNSNames with blank components are
not permitted");
79 throw new IOException("DNSNames may not begin or end with
a .");
Use the singular "DNSName" to be consistent with the other exception
messages.
--Sean
On 11/23/18 11:45 AM,
Hi Weijun!
A few comments.
1)
Since PRNG is Serializable, shouldn't `ctxt` be declared transient?
2)
The documentation of Cleaner [1] suggests not to use lambdas for
cleaning actions, as it may accidentally capture a reference to the
object being cleaned.
[1]
https://docs.oracle.com/en
Thanks a lot. Some comments inline.
> On Nov 29, 2018, at 1:55 AM, Nico Williams wrote:
>
> On Tue, Nov 20, 2018 at 09:56:36AM +0800, Weijun Wang wrote:
>> Please take a review at
>>
>> https://cr.openjdk.java.net/~weijun/6722928/webrev.01/
>>
>> We ported [1] the native GSS bridge to Window
Hi,
The NSS 3.16 source in test/jdk/sun/security/pkcs11/nss/src is not
needed anymore, so just remove it.
diff -r 1d520c376105
test/jdk/sun/security/pkcs11/nss/src/nss-3.16-with-nspr-4.10.4.tar.gz
Binary file
test/jdk/sun/security/pkcs11/nss/src/nss-3.16-with-nspr-4.10.4.tar.gz
has changed
d
